Skip to content

Move security alerts out of Experimental settings on Extension#22813

Merged
segun merged 5 commits intodevelopfrom
olu/move-security-alerts-settings
Feb 7, 2024
Merged

Move security alerts out of Experimental settings on Extension#22813
segun merged 5 commits intodevelopfrom
olu/move-security-alerts-settings

Conversation

@segun
Copy link
Copy Markdown
Contributor

@segun segun commented Feb 5, 2024

Description

We should move security alerts feature out of Settings > Experimental to Settings > Security & Privacy under the Security section below the SRP reveal feature.

Related issues

Fixes: #1764

Manual testing steps

  1. Go to this Settings -> Experimental
  2. You should see blockaid settings
  3. Go to Settings -> Security & privacy
  4. You should NOT see blockaid under SRP Reveal
  5. Checkout this branch
  6. Go to this Settings -> Experimental
  7. You should NOT see blockaid settings
  8. Go to Settings -> Security & privacy
  9. You should see blockaid under SRP Reveal

Screenshots/Recordings

Before

before_move.mov

After

after_move_sse.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@segun segun added team-confirmations-secure-ux-PR PRs from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Feb 5, 2024
@segun segun self-assigned this Feb 5, 2024
@segun segun requested a review from a team as a code owner February 5, 2024 15:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@segun segun force-pushed the olu/move-security-alerts-settings branch from 9d50c79 to b3a3d75 Compare February 5, 2024 15:30
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b3636d2) 68.41% compared to head (437f853) 68.42%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #22813      +/-   ##
===========================================
+ Coverage    68.41%   68.42%   +0.01%     
===========================================
  Files         1089     1089              
  Lines        42886    42887       +1     
  Branches     11405    11405              
===========================================
+ Hits         29339    29342       +3     
+ Misses       13547    13545       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@segun segun merged commit 635901a into develop Feb 7, 2024
@segun segun deleted the olu/move-security-alerts-settings branch February 7, 2024 08:41
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 7, 2024
@metamaskbot metamaskbot added the release-11.11.0 Issue or pull request that will be included in release 11.11.0 label Feb 7, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 7, 2024

Builds ready [437f853]
Page Load Metrics (712 ± 19 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7416794199
domContentLoaded8191431
load6498117124019
domInteractive8191431
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -48 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

+1 more reviewer

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@segun segun

Labels

release-11.11.0 Issue or pull request that will be included in release 11.11.0 team-confirmations-secure-ux-PR PRs from the confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@segun @metamaskbot @jpuri @blackdevelopa