Skip to content

Confirmation redesign: adding title to personal sign component#22749

Merged
jpuri merged 5 commits intodevelopfrom
personal_sign_title
Feb 6, 2024
Merged

Confirmation redesign: adding title to personal sign component#22749
jpuri merged 5 commits intodevelopfrom
personal_sign_title

Conversation

@jpuri
Copy link
Copy Markdown
Contributor

@jpuri jpuri commented Jan 31, 2024 •
edited
Loading

Description

Adding title and sedcription to personal sign page.

Related issues

Fixes: MetaMask/MetaMask-planning#1512

Manual testing steps

  1. Locally enable confirmation re-design
  2. Submit personal sign from test dapp
  3. Check MetaMask personal sign page

Screenshots/Recordings

Screenshot 2024-01-31 at 3 48 55 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added team-confirmations-secure-ux-PR PRs from the confirmations team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) confirmation-redesign labels Jan 31, 2024
@jpuri jpuri requested a review from a team as a code owner January 31, 2024 11:15
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 31, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (862617d) 68.11% compared to head (cff8515) 68.12%.
Report is 8 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #22749      +/-   ##
===========================================
+ Coverage    68.11%   68.12%   +0.01%     
===========================================
  Files         1087     1088       +1     
  Lines        42794    42795       +1     
  Branches     11381    11381              
===========================================
+ Hits         29148    29154       +6     
+ Misses       13646    13641       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 1, 2024

Builds ready [cff8515]
Page Load Metrics (812 ± 25 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint91150116157
domContentLoaded10361763
load7379268125225
domInteractive10351763
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri merged commit 8385506 into develop Feb 6, 2024
@jpuri jpuri deleted the personal_sign_title branch February 6, 2024 07:42
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 6, 2024
@metamaskbot metamaskbot added the release-11.11.0 Issue or pull request that will be included in release 11.11.0 label Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@segun segun segun approved these changes

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

confirmation-redesign release-11.11.0 Issue or pull request that will be included in release 11.11.0 team-confirmations-secure-ux-PR PRs from the confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jpuri @metamaskbot @segun @blackdevelopa