test: [Snaps E2E] Create E2E test for UI links#22739
Merged
FrederikBolding merged 8 commits intodevelopfrom Apr 15, 2024
Merged
test: [Snaps E2E] Create E2E test for UI links#22739FrederikBolding merged 8 commits intodevelopfrom
FrederikBolding merged 8 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [97744ec]
Page Load Metrics (1878 ± 67 ms)
Bundle size diffs
|
FrederikBolding
requested changes
Feb 26, 2024
Collaborator
Builds ready [6b085be]
Page Load Metrics (1856 ± 83 ms)
Bundle size diffs
|
| }); | ||
|
|
||
| // wait for and click back button | ||
| await driver.waitForSelector({ |
Member
There was a problem hiding this comment.
Should we not test that it opens the window?
Contributor
Author
There was a problem hiding this comment.
If you're questioning testing that the dialog with the URL from the link, that is done from 92-95 as it is detecting that the correct address comes up before backing out of the modal to the approve button.
Are you suggesting that we click through to make sure that opening a new tab with the intended link also works?
Contributor
Author
There was a problem hiding this comment.
Added in the latest commit. It required adding hosts to the privacy snapshot but it works.
Collaborator
Builds ready [1c3becf]
Page Load Metrics (1079 ± 424 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #22739 +/- ##
========================================
Coverage 68.72% 68.72%
========================================
Files 1105 1105
Lines 43248 43248
Branches 11561 11561
========================================
Hits 29718 29718
Misses 13530 13530 ☔ View full report in Codecov by Sentry. |
FrederikBolding
approved these changes
Mar 18, 2024
GuillaumeRx
approved these changes
Apr 15, 2024
pedronfigueiredo
approved these changes
Apr 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create E2E test for UI links
Related issues
Fixes: #22425
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist