Skip to content

Add script to generate RC commits#22673

Merged
chloeYue merged 7 commits intodevelopfrom
gitdiff-poc
Jan 29, 2024
Merged

Add script to generate RC commits#22673
chloeYue merged 7 commits intodevelopfrom
gitdiff-poc

Conversation

@chloeYue
Copy link
Copy Markdown
Contributor

@chloeYue chloeYue commented Jan 26, 2024 •
edited
Loading

Description

This script is used to filter and group commits by teams based on unique commit messages. It takes two branches as input and generates a CSV file with the commit hash, commit message, author, team, and PR link.
Command to run the script: node generate-rc-commits.js origin/branchA origin/branchB
Output: the generated commits will be in a file named 'commits.csv'.

Related issues

Fixes: https://github.com/MetaMask/extension-delivery/issues/138

Manual testing steps

Pull the branch and try running it with two branches to see if commits are generated

Screenshots/Recordings

Screenshot 2024-01-26 at 10 39 42

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chloeYue chloeYue requested a review from a team as a code owner January 26, 2024 09:39
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 26, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Jan 26, 2024 •
edited
Loading

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@kwsites/file-exists@1.1.1 filesystem Transitive: environment +1 56.7 kB steveukx
npm/@kwsites/promise-deferred@1.1.1 None 0 6.2 kB steveukx
npm/simple-git@3.22.0 shell Transitive: environment, filesystem +3 950 kB steveukx

View full report↗︎

@socket-security
Copy link
Copy Markdown

socket-security bot commented Jan 26, 2024 •
edited
Loading

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
No README npm/@kwsites/promise-deferred@1.1.1
Shell access npm/simple-git@3.22.0

View full report↗︎

Next steps

Why are READMEs important?

Package does not have a README. This may indicate a failed publish or a low quality package.

Add a README to to the package and publish a new version.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@kwsites/promise-deferred@1.1.1
  • @SocketSecurity ignore npm/simple-git@3.22.0

@chloeYue chloeYue self-assigned this Jan 26, 2024
@chloeYue chloeYue requested a review from kumavis as a code owner January 26, 2024 13:01
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 26, 2024

Builds ready [9e6f9fa]
Page Load Metrics (805 ± 21 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint891761182211
domContentLoaded9501594
load7268918054421
domInteractive9501594
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@chloeYue chloeYue merged commit 4d66bd8 into develop Jan 29, 2024
@chloeYue chloeYue deleted the gitdiff-poc branch January 29, 2024 15:28
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
@metamaskbot metamaskbot added the release-11.11.0 Issue or pull request that will be included in release 11.11.0 label Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DDDDDanica DDDDDanica DDDDDanica approved these changes

@kumavis kumavis Awaiting requested review from kumavis kumavis is a code owner

+1 more reviewer

@benjisclowder benjisclowder benjisclowder approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@chloeYue chloeYue

Labels

extension-delivery release-11.11.0 Issue or pull request that will be included in release 11.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chloeYue @metamaskbot @DDDDDanica @benjisclowder @danjm