Updating design tokens to 1.13 includes accessibility updates#22658
Merged
HowardBraham merged 3 commits intodevelopfrom Jan 29, 2024
Merged
Updating design tokens to 1.13 includes accessibility updates#22658HowardBraham merged 3 commits intodevelopfrom
HowardBraham merged 3 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
ad80912 to
f5793ad
Compare
Collaborator
Builds ready [a72e8e1]
Page Load Metrics (865 ± 31 ms)
Bundle size diffs
|
Collaborator
Builds ready [eeee83c]
Page Load Metrics (792 ± 32 ms)
Bundle size diffs
|
garrettbear
approved these changes
Jan 25, 2024
darkwing
approved these changes
Jan 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the design-tokens package to
v1.13.0, introducing accessibility enhancements to various color categories, includingwarning/default,success/default, and inverse colors. Additionally, it incorporates hover and pressed tokens.For a detailed overview of the color updates, please refer to this PR in the design-tokens repository.
The accessibility improvements ensure that:
warning/defaultcolor now meets WCAG AA color contrast requirements.success/defaultcolor now meets WCAG AA color contrast requirements.primary/inverse,error/inverse,success/inverse, andinfo/inversecolors in dark mode now meets WCAG AA color contrast requirements.These updates enhance the accessibility and user experience for vision impaired folks in the extension.
Related issues
Related: https://github.com/MetaMask/metamask-extension#workspaces/design-system-61e8a2ae77c3a60012e5003c/issues/zh/329
Manual testing steps
The easiest way to review these accessibility updates is to check storybook
HelpTextin the search barSeveritystoryButtonstoryScreenshots/Recordings
Before
Screencast below shows accessibility color contrast tests fail for warning/default, success/default on the
HelpTextcomponent and primary/inverse on theButtoncomponent in dark modebefore.storybook1080.mov
Below screencast shows current view of the extension before color updates
before.mov
After
Screencast below shows accessibility color contrast tests now pass for warning/default, success/default on the
HelpTextcomponent and primary/inverse on theButtoncomponent in dark modeafter.storybook1080.mov
Below screencast shows updated view of the extension after color updates
after.mov
Pre-merge author checklist
Pre-merge reviewer checklist