UX: Add event tracking for empty banner displays by darkwing · Pull Request #22654 · MetaMask/metamask-extension

darkwing · 2024-01-24T15:18:22Z

Description

Adds event tracking for the new "Buy", "Receive", and "NFT" banners.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1949

Manual testing steps

Create a new wallet (will have 0 balance, 0 NFTs)
Open ui/contexts/metametrics.js and in the trackEvent function, add a console.log to see the events get recorded (or use Logpoints in the debugger)

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-01-24T15:18:35Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

ui/contexts/metametrics.js

metamaskbot · 2024-02-01T15:28:35Z

Builds ready [d40792c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (803 ± 26 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	96	151	117	15	7
		domContentLoaded	10	36	17	6	3
		load	722	939	803	54	26
		domInteractive	10	36	17	6	3

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 2.57 KiB (0.04%)
common: 338 Bytes (0.01%)

DDDDDanica · 2024-02-01T17:32:56Z

ui/components/app/asset-list/asset-list.js

+          chain_id: currentNetwork.chainId,
+          locale: currentLocale,
+          network: currentNetwork.nickname,
+          referrer: ORIGIN_METAMASK,


Nit: we can extract them to a property object and use it for different events tracked in this file

I can do that in a follow up as it's not core and I do kind of like the context of what the nickname and chainId belong to!

codecov · 2024-02-07T19:51:20Z

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (642f6d4) 68.47% compared to head (93a3a68) 68.49%.
Report is 7 commits behind head on develop.

Files	Patch %	Lines
ui/components/app/nfts-tab/nfts-tab.js	70.00%	3 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #22654      +/-   ##
===========================================
+ Coverage    68.47%   68.49%   +0.02%     
===========================================
  Files         1089     1089              
  Lines        42905    42926      +21     
  Branches     11426    11429       +3     
===========================================
+ Hits         29378    29400      +22     
+ Misses       13527    13526       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-02-07T20:02:08Z

Builds ready [93a3a68]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (818 ± 42 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	85	133	102	14	7
		domContentLoaded	9	30	18	6	3
		load	735	1114	818	87	42
		domInteractive	9	30	18	6	3

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 2.28 KiB (0.03%)
common: 338 Bytes (0.01%)

darkwing requested a review from a team as a code owner January 24, 2024 15:18

darkwing marked this pull request as draft January 24, 2024 15:18

darkwing force-pushed the 1949-asset-list-event-tracking branch from 4ba64f8 to 0d3845e Compare January 24, 2024 15:50

darkwing added team-extension-client labels Jan 26, 2024

darkwing marked this pull request as ready for review January 26, 2024 18:30

darkwing force-pushed the 1949-asset-list-event-tracking branch from d89aadb to b73cc6e Compare January 31, 2024 19:19

NidhiKJha previously approved these changes Feb 1, 2024

View reviewed changes

ui/contexts/metametrics.js Outdated Show resolved Hide resolved

darkwing dismissed NidhiKJha’s stale review via d40792c February 1, 2024 14:56

DDDDDanica reviewed Feb 1, 2024

View reviewed changes

darkwing added 5 commits February 7, 2024 13:32

UX: Add event tracking for empty banner displays

e268942

Add display and click events

0279352

Fix unit tests

78dcb92

Fix category

e0871b5

Fix limnt

93a3a68

darkwing force-pushed the 1949-asset-list-event-tracking branch from d40792c to 93a3a68 Compare February 7, 2024 19:35

darkwing added the needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. label Feb 8, 2024

NidhiKJha approved these changes Feb 8, 2024

View reviewed changes

vthomas13 approved these changes Feb 8, 2024

View reviewed changes

darkwing merged commit 6db80f1 into develop Feb 8, 2024

darkwing deleted the 1949-asset-list-event-tracking branch February 8, 2024 22:04

github-actions bot locked and limited conversation to collaborators Feb 8, 2024

metamaskbot added the release-11.12.0 Issue or pull request that will be included in release 11.12.0 label Feb 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UX: Add event tracking for empty banner displays#22654

UX: Add event tracking for empty banner displays#22654
darkwing merged 5 commits intodevelopfrom
1949-asset-list-event-tracking

darkwing commented Jan 24, 2024 •

edited

Loading

Uh oh!

github-actions bot commented Jan 24, 2024

Uh oh!

Uh oh!

metamaskbot commented Feb 1, 2024

Uh oh!

DDDDDanica Feb 1, 2024

Uh oh!

darkwing Feb 8, 2024

Uh oh!

codecov bot commented Feb 7, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Feb 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

darkwing commented Jan 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jan 24, 2024

Uh oh!

Uh oh!

metamaskbot commented Feb 1, 2024

Uh oh!

DDDDDanica Feb 1, 2024

Choose a reason for hiding this comment

Uh oh!

darkwing Feb 8, 2024

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Feb 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented Feb 7, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

darkwing commented Jan 24, 2024 •

edited

Loading

codecov bot commented Feb 7, 2024 •

edited

Loading