Skip to content

Account list e2e test: split account details e2e tests into multiple files and improve test names#22635

Merged
chloeYue merged 11 commits intodevelopfrom
chloe-flaky-tests
Jan 24, 2024
Merged

Account list e2e test: split account details e2e tests into multiple files and improve test names#22635
chloeYue merged 11 commits intodevelopfrom
chloe-flaky-tests

Conversation

@chloeYue
Copy link
Copy Markdown
Contributor

@chloeYue chloeYue commented Jan 23, 2024 •
edited
Loading

Description

This PR dose two things:

  • Split the tests in previous account-details.spec.js file into multiple files and placed them in one account-menu folder. Since some tests weren't actually belong to account details being in the account-details file, I split them into new test files for pin/unpin and hide/unhide actions.

  • I also enhanced some test names to be more descriptive.

Related issues

Fixes: #22565

Manual testing steps

Run the e2e test.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@chloeYue chloeYue self-assigned this Jan 23, 2024
@chloeYue chloeYue requested a review from a team as a code owner January 23, 2024 10:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 23, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chloeYue chloeYue changed the title [Draft] Fix flaky tests Fix flaky test: show account details should unpin the account when unpin is clicked Jan 23, 2024
@chloeYue chloeYue mentioned this pull request Jan 23, 2024
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (722d8fe) 68.13% compared to head (384cd22) 68.13%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #22635   +/-   ##
========================================
  Coverage    68.13%   68.13%           
========================================
  Files         1087     1087           
  Lines        42665    42665           
  Branches     11349    11349           
========================================
  Hits         29066    29066           
  Misses       13599    13599

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 23, 2024

Builds ready [e25b190]
Page Load Metrics (1248 ± 112 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint882761736833
domContentLoaded10192757637
load81216431248234112
domInteractive10192757637
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Gudahtt
Gudahtt reviewed Jan 23, 2024
View reviewed changes
@chloeYue chloeYue requested a review from Gudahtt January 23, 2024 20:58
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 23, 2024

Builds ready [aa1ed93]
Page Load Metrics (896 ± 61 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint941801302110
domContentLoaded96125168
load698110189612761
domInteractive96125168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@chloeYue chloeYue changed the title Fix flaky test: show account details should unpin the account when unpin is clicked Account list e2e test: split current account details e2e tests into multiple files and improve the test names Jan 23, 2024
@chloeYue chloeYue changed the title Account list e2e test: split current account details e2e tests into multiple files and improve the test names Account list e2e test: split account details e2e tests into multiple files and improve the test names Jan 23, 2024
@chloeYue chloeYue changed the title Account list e2e test: split account details e2e tests into multiple files and improve the test names Account list e2e test: split account details e2e tests into multiple files and improve test names Jan 23, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 24, 2024

Builds ready [384cd22]
Page Load Metrics (841 ± 28 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint104146123136
domContentLoaded105222105
load7589378415928
domInteractive105222105
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@chloeYue chloeYue merged commit f8273b9 into develop Jan 24, 2024
@chloeYue chloeYue deleted the chloe-flaky-tests branch January 24, 2024 14:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
@metamaskbot metamaskbot added the release-11.10.0 Issue or pull request that will be included in release 11.10.0 label Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@HowardBraham HowardBraham HowardBraham approved these changes

@NidhiKJha NidhiKJha NidhiKJha approved these changes

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

Assignees

@chloeYue chloeYue

Labels

release-11.10.0 Issue or pull request that will be included in release 11.10.0 team-extension-platform Extension Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix "Show account details should unpin the account when u..." flaky tests

5 participants

@chloeYue @metamaskbot @HowardBraham @Gudahtt @NidhiKJha