Skip to content

UX: Updated connections icon#22634

Merged
darkwing merged 6 commits intodevelopfrom
fix-planning-1951
Jan 29, 2024
Merged

UX: Updated connections icon#22634
darkwing merged 6 commits intodevelopfrom
fix-planning-1951

Conversation

@NidhiKJha
Copy link
Copy Markdown
Member

@NidhiKJha NidhiKJha commented Jan 23, 2024

This PR is to update the connections icon from global menu to the connected dapp icon

Related issues

Fixes: #1951

Manual testing steps

  1. Connect MetaMask to Uniswap or test-dapp
  2. Check the connections icon is changed to the dapp icon
  3. Disconnect the dapp. Check the icon is back to Global Icon

Screenshots/Recordings

Before

Screenshot 2024-01-23 at 2 24 12 PM

After

Screenshot 2024-01-23 at 2 25 01 PM

Screenshot 2024-01-23 at 2 24 30 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha requested a review from a team as a code owner January 23, 2024 08:55
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jan 23, 2024
darkwing
darkwing reviewed Jan 23, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this display in the UI anywhere yet?

ui/components/multichain/connected-site-menu/connected-site-menu.js Outdated
Boolean(connectedSubjectsMetadata?.iconUrl) ||
status === STATUS_CONNECTED_TO_ANOTHER_ACCOUNT ||
status === STATUS_CONNECTED_TO_SNAP;
console.log(
Copy link
Copy Markdown
Contributor

@darkwing darkwing Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: console.log needs removal.

Copy link
Copy Markdown
Member Author

@NidhiKJha NidhiKJha Jan 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated here 6413cc3

@NidhiKJha
Copy link
Copy Markdown
Member Author

NidhiKJha commented Jan 23, 2024

Does this display in the UI anywhere yet?

@darkwing Yeah, in the popup view.

  1. Go to uniswap.
  2. Connect MetaMask to Uniswap or test-dapp
  3. Check the connections icon is changed to the dapp icon

@NidhiKJha NidhiKJha requested a review from darkwing January 23, 2024 15:19
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 24, 2024 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (978e57a) 68.12% compared to head (e1ddf8e) 68.12%.
Report is 18 commits behind head on develop.

Files Patch % Lines
...tichain/connected-site-menu/connected-site-menu.js 85.71% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #22634      +/-   ##
===========================================
- Coverage    68.12%   68.12%   -0.01%     
===========================================
  Files         1087     1087              
  Lines        42663    42669       +6     
  Branches     11349    11352       +3     
===========================================
+ Hits         29064    29065       +1     
- Misses       13599    13604       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 24, 2024

Builds ready [e1ddf8e]
Page Load Metrics (829 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint85141112147
domContentLoaded95618126
load72910828298742
domInteractive95618126
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 225 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@darkwing darkwing merged commit 116f480 into develop Jan 29, 2024
@darkwing darkwing deleted the fix-planning-1951 branch January 29, 2024 21:43
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
@metamaskbot metamaskbot added the release-11.11.0 Issue or pull request that will be included in release 11.11.0 label Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DDDDDanica DDDDDanica DDDDDanica approved these changes

+1 more reviewer

@darkwing darkwing darkwing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-11.11.0 Issue or pull request that will be included in release 11.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@NidhiKJha @metamaskbot @darkwing @DDDDDanica