UX: Add 'Add' icon to Add Network button by darkwing · Pull Request #22628 · MetaMask/metamask-extension

darkwing · 2024-01-22T21:37:33Z

Description

Design wanted to add the "+" to the Add Network button

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1941

Manual testing steps

Open the network menu
See the "+" icon on the button

Screenshots/Recordings

Before

N/A

After

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-01-22T21:37:47Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2024-01-22T22:02:08Z

Builds ready [6b3a1e8]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1286 ± 121 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	93	298	202	68	33
		domContentLoaded	10	189	93	80	38
		load	1005	1703	1286	253	121
		domInteractive	10	189	93	80	38

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 29 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-01-23T18:45:14Z

Builds ready [275c006]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (752 ± 17 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	96	133	108	10	5
		domContentLoaded	9	21	15	3	2
		load	719	846	752	35	17
		domInteractive	9	21	15	3	2

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 29 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2024-01-24T15:53:56Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (05d2bfd) 68.18% compared to head (60837ac) 68.18%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #22628      +/-   ##
===========================================
- Coverage    68.18%   68.18%   -0.00%     
===========================================
  Files         1087     1087              
  Lines        42674    42674              
  Branches     11352    11352              
===========================================
- Hits         29096    29095       -1     
- Misses       13578    13579       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-01-24T16:18:48Z

Builds ready [60837ac]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (771 ± 14 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	95	153	111	13	6
		domContentLoaded	10	44	18	7	3
		load	709	837	771	29	14
		domInteractive	10	44	18	7	3

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 29 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-01-26T19:03:18Z

Builds ready [ee76225]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (931 ± 72 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	96	293	141	41	20
		domContentLoaded	17	207	41	41	20
		load	732	1439	931	150	72
		domInteractive	17	207	41	41	20

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 29 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2024-01-29T16:19:36Z

Builds ready [3b55461]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (882 ± 31 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	114	175	133	14	7
		domContentLoaded	13	54	26	10	5
		load	783	1039	882	64	31
		domInteractive	13	54	26	10	5

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 29 Bytes (0.00%)
common: 0 Bytes (0.00%)

UX: Add 'Add' icon to Add Network button

6b3a1e8

darkwing requested a review from a team as a code owner January 22, 2024 21:37

NidhiKJha approved these changes Jan 23, 2024

View reviewed changes

darkwing added team-extension-client labels Jan 23, 2024

Merge branch 'develop' into add-button

275c006

Merge branch 'develop' into add-button

60837ac

darkwing added 3 commits January 25, 2024 08:26

Merge branch 'develop' into add-button

3ea9e57

Merge branch 'develop' into add-button

48e7b6c

Merge branch 'develop' into add-button

ee76225

darkwing added 2 commits January 29, 2024 09:13

Merge branch 'develop' into add-button

f5ce0eb

Merge branch 'develop' into add-button

3b55461

georgewrmarshall approved these changes Jan 29, 2024

View reviewed changes

darkwing merged commit 46e755b into develop Jan 29, 2024

darkwing deleted the add-button branch January 29, 2024 16:17

github-actions bot locked and limited conversation to collaborators Jan 29, 2024

metamaskbot added the release-11.11.0 Issue or pull request that will be included in release 11.11.0 label Jan 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UX: Add 'Add' icon to Add Network button#22628

UX: Add 'Add' icon to Add Network button#22628
darkwing merged 8 commits intodevelopfrom
add-button

darkwing commented Jan 22, 2024

Uh oh!

github-actions bot commented Jan 22, 2024

Uh oh!

metamaskbot commented Jan 22, 2024

Uh oh!

metamaskbot commented Jan 23, 2024

Uh oh!

codecov bot commented Jan 24, 2024

Uh oh!

metamaskbot commented Jan 24, 2024

Uh oh!

metamaskbot commented Jan 26, 2024

Uh oh!

metamaskbot commented Jan 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

darkwing commented Jan 22, 2024

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jan 22, 2024

Uh oh!

metamaskbot commented Jan 22, 2024

Uh oh!

metamaskbot commented Jan 23, 2024

Uh oh!

codecov bot commented Jan 24, 2024

Codecov Report

Uh oh!

metamaskbot commented Jan 24, 2024

Uh oh!

metamaskbot commented Jan 26, 2024

Uh oh!

metamaskbot commented Jan 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants