Skip to content

UX: Multichain: Remove bottom navigation#22623

Merged
darkwing merged 7 commits intodevelopfrom
multichain-remove-bottom-nav
Jan 30, 2024
Merged

UX: Multichain: Remove bottom navigation#22623
darkwing merged 7 commits intodevelopfrom
multichain-remove-bottom-nav

Conversation

@darkwing
Copy link
Copy Markdown
Contributor

@darkwing darkwing commented Jan 22, 2024

Description

Removes the abandoned AppFooter, SelectActionModal, and the UI around it.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1824

Manual testing steps

  1. MULTICHAIN=1 yarn start
  2. No longer see the bottom navigation, do see the EthOverview buttons restored.

Screenshots/Recordings

Before

N/A

After

SCR-20240122-lify

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner January 22, 2024 18:35
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 22, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing force-pushed the multichain-remove-bottom-nav branch 3 times, most recently from a7fba9f to 32ff62b Compare January 24, 2024 16:13
@darkwing
UX: Multichain: Remove bottom navigation
966738d 
Remove missing locales

Fix E2Es
@darkwing darkwing force-pushed the multichain-remove-bottom-nav branch from 39c12cc to 966738d Compare January 25, 2024 18:11
@darkwing darkwing force-pushed the multichain-remove-bottom-nav branch from 8c685e7 to 93ff52f Compare January 26, 2024 20:05
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 29, 2024

Builds ready [b02bd4f]
Page Load Metrics (794 ± 16 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint93150110147
domContentLoaded84317105
load7528697943216
domInteractive84317105
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -23.95 KiB (-0.34%)
  • common: -647 Bytes (-0.01%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 30, 2024

Builds ready [be2c6d5]
Page Load Metrics (845 ± 46 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint861921252411
domContentLoaded97821167
load71210778459546
domInteractive97821167
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -23.95 KiB (-0.34%)
  • common: -647 Bytes (-0.01%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 30, 2024

Builds ready [e2624a3]
Page Load Metrics (799 ± 26 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint88141113136
domContentLoaded9431873
load6999717995526
domInteractive9431773
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -23.95 KiB (-0.34%)
  • common: -647 Bytes (-0.01%)

@darkwing darkwing merged commit 3cbe6a0 into develop Jan 30, 2024
@darkwing darkwing deleted the multichain-remove-bottom-nav branch January 30, 2024 18:57
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2024
@metamaskbot metamaskbot added the release-11.11.0 Issue or pull request that will be included in release 11.11.0 label Jan 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NidhiKJha NidhiKJha NidhiKJha approved these changes

+1 more reviewer

@vthomas13 vthomas13 vthomas13 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.11.0 Issue or pull request that will be included in release 11.11.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@darkwing @metamaskbot @vthomas13 @NidhiKJha