UX: Send Flow: Add 'Sent to Contract' warning to new send page#22551
Merged
UX: Send Flow: Add 'Sent to Contract' warning to new send page#22551
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
13 tasks
vthomas13
approved these changes
Jan 18, 2024
NidhiKJha
approved these changes
Jan 18, 2024
Comment on lines
+83
to
+91
| <a | ||
| key="contractWarningSupport" | ||
| target="_blank" | ||
| rel="noopener noreferrer" | ||
| className="send__warning-container__link" | ||
| href={CONTRACT_ADDRESS_LINK} | ||
| > | ||
| {t('learnMoreUpperCase')} | ||
| </a>, |
Member
There was a problem hiding this comment.
Nit: We can use ButtonLink here
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #22551 +/- ##
===========================================
+ Coverage 68.12% 68.18% +0.06%
===========================================
Files 1087 1087
Lines 42653 42664 +11
Branches 11349 11353 +4
===========================================
+ Hits 29056 29087 +31
+ Misses 13597 13577 -20 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [304600a]
Page Load Metrics (897 ± 29 ms)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the "You're sending to a contract" acknowledgement in the new send flow. This existed in the old send flow.
Related issues
N/A
Manual testing steps
0x514910771af9ca656af840dff83e8264ecf986ca; this is the $LINK token addressScreenshots/Recordings
Before
N/A
After
Pre-merge author checklist
Pre-merge reviewer checklist