Skip to content

Minor language fixes in messages.json-en#22550

Merged
HowardBraham merged 2 commits intoMetaMask:developfrom
bumblefudge:hotfix/messages.json-en-typo
Feb 13, 2024
Merged

Minor language fixes in messages.json-en#22550
HowardBraham merged 2 commits intoMetaMask:developfrom
bumblefudge:hotfix/messages.json-en-typo

Conversation

@bumblefudge
Copy link
Copy Markdown
Contributor

@bumblefudge bumblefudge commented Jan 16, 2024 •
edited
Loading

Description

Just some language tweaks I noticed using MMExt today.

Related issues

no idea

Manual testing steps

n/a just see the diffs/files changed

Screenshots/Recordings

n/a just see the diffs/files changed

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bumblefudge bumblefudge requested a review from a team as a code owner January 16, 2024 20:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 16, 2024 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bumblefudge
Copy link
Copy Markdown
Contributor Author

bumblefudge commented Jan 16, 2024

I have read the CLA Document and I hereby sign the CLA.

party on

HowardBraham
HowardBraham previously approved these changes Jan 17, 2024
View reviewed changes
@HowardBraham HowardBraham force-pushed the hotfix/messages.json-en-typo branch from 34db92e to 7b3e16f Compare January 18, 2024 07:52
@HowardBraham HowardBraham merged commit 391e9e7 into MetaMask:develop Feb 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 13, 2024
@metamaskbot metamaskbot added the release-11.12.0 Issue or pull request that will be included in release 11.12.0 label Mar 1, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Mar 1, 2024

No release label on PR. Adding release label release-11.12.0 on PR, as PR was added to branch 11.12.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@HowardBraham HowardBraham HowardBraham approved these changes

@coreyjanssen coreyjanssen coreyjanssen approved these changes

Assignees

No one assigned

Labels

external-contributor release-11.12.0 Issue or pull request that will be included in release 11.12.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bumblefudge @metamaskbot @HowardBraham @coreyjanssen