Skip to content

Update Gas API URL#22544

Merged
dan437 merged 3 commits intodevelopfrom
gas-api-url
Jan 25, 2024
Merged

Update Gas API URL#22544
dan437 merged 3 commits intodevelopfrom
gas-api-url

Conversation

@dan437
Copy link
Copy Markdown
Contributor

@dan437 dan437 commented Jan 16, 2024

Description

This PR updates a Gas API URL.

Testing

  • Try to do a Send or a Swap transaction. Don't submit it, just check that gas fees are showing well

@dan437 dan437 requested review from a team as code owners January 16, 2024 09:23
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jan 16, 2024
@dan437 dan437 added the team-swaps-deprecated DEPRECATED: please use "team-swaps-and-bridge" instead label Jan 16, 2024
@dan437 dan437 force-pushed the gas-api-url branch 3 times, most recently from 6be4dc0 to f7562f1 Compare January 19, 2024 14:07
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [f7562f1]
Page Load Metrics (1455 ± 174 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint963171867335
domContentLoaded10210687134
load94321001455362174
domInteractive10210687134
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -9 Bytes (-0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d3d67d5) 68.09% compared to head (86ac3ca) 68.09%.
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #22544   +/-   ##
========================================
  Coverage    68.09%   68.09%           
========================================
  Files         1087     1087           
  Lines        42728    42728           
  Branches     11364    11364           
========================================
  Hits         29093    29093           
  Misses       13635    13635           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [1393a11]
Page Load Metrics (1208 ± 103 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint842901436230
domContentLoaded9196496531
load78716661208215103
domInteractive9196496531
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -9 Bytes (-0.00%)

darkwing
darkwing previously approved these changes Jan 23, 2024
Copy link
Copy Markdown
Contributor

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can we use the constant in test files?

nikoferro
nikoferro previously approved these changes Jan 23, 2024
@dan437 dan437 dismissed stale reviews from nikoferro and darkwing via 3916057 January 24, 2024 15:12
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [3916057]
Page Load Metrics (991 ± 37 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1071891512110
domContentLoaded126236178
load86011289917837
domInteractive126236178
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -9 Bytes (-0.00%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [3916057]
Page Load Metrics (991 ± 37 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1071891512110
domContentLoaded126236178
load86011289917837
domInteractive126236178
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -9 Bytes (-0.00%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [d315f7c]
Page Load Metrics (817 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint89153112199
domContentLoaded9441873
load700108881711254
domInteractive9441873
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -9 Bytes (-0.00%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [86ac3ca]
Page Load Metrics (798 ± 18 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8812811095
domContentLoaded9471884
load7098757983818
domInteractive9471884
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: -9 Bytes (-0.00%)

Copy link
Copy Markdown
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

@dan437 dan437 merged commit 803948a into develop Jan 25, 2024
@dan437 dan437 deleted the gas-api-url branch January 25, 2024 16:38
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2024
@metamaskbot metamaskbot added the release-11.10.0 Issue or pull request that will be included in release 11.10.0 label Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-11.10.0 Issue or pull request that will be included in release 11.10.0 team-swaps-deprecated DEPRECATED: please use "team-swaps-and-bridge" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants