chore: add types for submitRequestToBackground fn in ui/store/actions.ts#22522
Merged
HowardBraham merged 4 commits intodevelopfrom Jan 27, 2024
Merged
chore: add types for submitRequestToBackground fn in ui/store/actions.ts#22522HowardBraham merged 4 commits intodevelopfrom
submitRequestToBackground fn in ui/store/actions.ts#22522HowardBraham merged 4 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
ui/store/actions.ts
Outdated
Comment on lines
3324
to
3332
| ): ThunkAction< | ||
| Promise< | ||
| [ | ||
| { destinationAmount: string; decimals: number; aggregator: string }, | ||
| string, | ||
| ] | ||
| >, | ||
| Promise<Quotes>, | ||
| MetaMaskReduxState, | ||
| unknown, | ||
| AnyAction | ||
| > { |
Contributor
There was a problem hiding this comment.
Prettier is requiring you to change the line breaks here
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #22522 +/- ##
========================================
Coverage 68.05% 68.05%
========================================
Files 1087 1087
Lines 42798 42798
Branches 11372 11372
========================================
Hits 29122 29122
Misses 13676 13676 ☔ View full report in Codecov by Sentry. |
HowardBraham
approved these changes
Jan 26, 2024
Collaborator
Builds ready [5e39f36]
Page Load Metrics (836 ± 35 ms)
Bundle size diffs
|
danjm
approved these changes
Jan 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I'm working on updating our TypeScript version to v5.3.3, and this code will fail to typecheck in the newest version. There are a dependency issues to work through, so I'm PRring ahead of the other updates since it can't hurt to have some better types now.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist