Skip to content

docs: tell vscode to use our workspace's typescript version for typechecks/hints#22520

Merged
HowardBraham merged 4 commits intodevelopfrom
vscode-use-ts
Jan 29, 2024
Merged

docs: tell vscode to use our workspace's typescript version for typechecks/hints#22520
HowardBraham merged 4 commits intodevelopfrom
vscode-use-ts

Conversation

@davidmurdoch
Copy link
Copy Markdown
Contributor

@davidmurdoch davidmurdoch commented Jan 12, 2024

Description

The default setting in VSCode it for it to use its own version of TypeScript when Typechecking and providing type hints. This PR changes it to use our workspace version.

image

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@davidmurdoch davidmurdoch requested a review from a team as a code owner January 12, 2024 16:23
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 12, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@HowardBraham
Copy link
Copy Markdown
Contributor

HowardBraham commented Jan 13, 2024

I think some people are going to object to removing
"javascript.preferences.importModuleSpecifier": "relative"
(not me, my preference is actually shortest, but I remember others wanted relative)

@davidmurdoch
Copy link
Copy Markdown
Contributor Author

davidmurdoch commented Jan 14, 2024

I think some people are going to object to removing "javascript.preferences.importModuleSpecifier": "relative" (not me, my preference is actually shortest, but I remember others wanted relative)

Oh yikes! The removal was purely an oversight on my part when preparing this PR! I should have be more careful.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 14, 2024

Builds ready [db6e287]
Page Load Metrics (1288 ± 105 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint852631404622
domContentLoaded10181374823
load81316631288219105
domInteractive10181374823
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

HowardBraham
HowardBraham previously approved these changes Jan 15, 2024
View reviewed changes
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 26, 2024

Builds ready [c459a88]
Page Load Metrics (858 ± 47 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint961781232211
domContentLoaded96723136
load72911238589847
domInteractive96723136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@HowardBraham HowardBraham merged commit 72ace4f into develop Jan 29, 2024
@HowardBraham HowardBraham deleted the vscode-use-ts branch January 29, 2024 21:09
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2024
@metamaskbot metamaskbot added the release-11.11.0 Issue or pull request that will be included in release 11.11.0 label Jan 29, 2024
@gauthierpetetin gauthierpetetin added the team-extension-platform Extension Platform team label Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@HowardBraham HowardBraham HowardBraham approved these changes

+1 more reviewer

@danjm danjm danjm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.11.0 Issue or pull request that will be included in release 11.11.0 team-extension-platform Extension Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@davidmurdoch @HowardBraham @metamaskbot @danjm @gauthierpetetin