Skip to content

Petnames: Add more e2e tests#22515

Merged
dbrans merged 19 commits intodevelopfrom
dbrans/petnames-e2e
Jan 20, 2024
Merged

Petnames: Add more e2e tests#22515
dbrans merged 19 commits intodevelopfrom
dbrans/petnames-e2e

Conversation

@dbrans
Copy link
Copy Markdown
Contributor

@dbrans dbrans commented Jan 12, 2024 •
edited
Loading

Description

Related issues

Manual testing steps

To run these e2e tests:

yarn test:e2e:single --browser=chrome test/e2e/flask/petnames-transactions.spec.js --leave-running

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 12, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

dbrans
dbrans commented Jan 12, 2024
View reviewed changes
dbrans
dbrans commented Jan 12, 2024
View reviewed changes
@dbrans dbrans mentioned this pull request Jan 12, 2024
Merged
14 tasks
@dbrans dbrans changed the title Petnames: Add more e2e tests and address previous comments Petnames: Add more e2e tests Jan 12, 2024
@dbrans dbrans added the team-confirmations-system-deprecated DEPRECATED: please use "team-confirmations" instead label Jan 12, 2024
@dbrans dbrans marked this pull request as ready for review January 12, 2024 18:25
@dbrans dbrans requested a review from a team as a code owner January 12, 2024 18:25
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 12, 2024

Builds ready [02c1fc6]
Page Load Metrics (1291 ± 135 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint882891505727
domContentLoaded9192455928
load82217111291281135
domInteractive9192455928
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -74 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 12, 2024 •
edited
Loading

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (fcd2b66) 68.15% compared to head (980a707) 68.14%.

Files Patch % Lines
...nder-to-recipient/sender-to-recipient.component.js 60.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #22515      +/-   ##
===========================================
- Coverage    68.15%   68.14%   -0.00%     
===========================================
  Files         1086     1086              
  Lines        42611    42608       -3     
  Branches     11343    11342       -1     
===========================================
- Hits         29038    29035       -3     
  Misses       13573    13573

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 15, 2024

Builds ready [f80773e]
Page Load Metrics (1145 ± 126 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint842661325828
domContentLoaded9182435828
load79116471145263126
domInteractive9182435828
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -74 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 15, 2024

Builds ready [fb11a9a]
Page Load Metrics (1582 ± 191 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint963131926833
domContentLoaded16219656833
load84321811582397191
domInteractive16219656833
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -74 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

OGPoyraz
OGPoyraz previously approved these changes Jan 16, 2024
View reviewed changes
matthewwalsh0
matthewwalsh0 reviewed Jan 16, 2024
View reviewed changes
matthewwalsh0
matthewwalsh0 reviewed Jan 16, 2024
View reviewed changes
matthewwalsh0
matthewwalsh0 reviewed Jan 16, 2024
View reviewed changes
matthewwalsh0
matthewwalsh0 previously approved these changes Jan 16, 2024
View reviewed changes
vinistevam
vinistevam previously approved these changes Jan 17, 2024
View reviewed changes
@dbrans dbrans dismissed stale reviews from vinistevam and matthewwalsh0 via b688014 January 18, 2024 15:31
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 19, 2024

Builds ready [8f5849c]
Page Load Metrics (1223 ± 126 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint962852176833
domContentLoaded102061207737
load101019111223262126
domInteractive102061207737
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -74 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 19, 2024

Builds ready [980a707]
Page Load Metrics (1298 ± 155 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint974631978742
domContentLoaded10183777034
load93922001298324155
domInteractive10183777034
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -74 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@dbrans dbrans merged commit 16b62a8 into develop Jan 20, 2024
@dbrans dbrans deleted the dbrans/petnames-e2e branch January 20, 2024 20:02
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2024
@metamaskbot metamaskbot added the release-11.10.0 Issue or pull request that will be included in release 11.10.0 label Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

@vinistevam vinistevam vinistevam approved these changes

@OGPoyraz OGPoyraz OGPoyraz left review comments

Assignees

No one assigned

Labels

release-11.10.0 Issue or pull request that will be included in release 11.10.0 team-confirmations-system-deprecated DEPRECATED: please use "team-confirmations" instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dbrans @metamaskbot @OGPoyraz @matthewwalsh0 @vinistevam