feat: new notification components#22509
Merged
matteoscurati merged 41 commits intodevelopfrom Mar 8, 2024
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
darkwing
suggested changes
Jan 12, 2024
Contributor
darkwing
left a comment
There was a problem hiding this comment.
Just a few comments here
ui/components/multichain/notification-detail/notification-detail.tsx
Outdated
Show resolved
Hide resolved
ui/components/multichain/notification-list-item-text/notification-list-item-text.tsx
Outdated
Show resolved
Hide resolved
fdec73a to
e08e8da
Compare
Collaborator
Builds ready [e08e8da]
Page Load Metrics (1183 ± 57 ms)
Bundle size diffs
|
6b88a8e to
153d73c
Compare
Contributor
Author
|
@darkwing I had already reviewed your comments and now, due to some conflicts, I have performed a force push. |
Collaborator
Builds ready [5b788e0]
Page Load Metrics (1309 ± 379 ms)
Bundle size diffs
|
Collaborator
Builds ready [9c30fa5]
Page Load Metrics (1220 ± 410 ms)
Bundle size diffs
|
Collaborator
Builds ready [daee18b]
Page Load Metrics (1182 ± 442 ms)
Bundle size diffs
|
Collaborator
Builds ready [a4a547e]
Page Load Metrics (1433 ± 383 ms)
Bundle size diffs
|
Collaborator
Builds ready [f66151c]
Page Load Metrics (886 ± 433 ms)
Bundle size diffs
|
Collaborator
Builds ready [9166964]
Page Load Metrics (1234 ± 368 ms)
Bundle size diffs
|
darkwing
approved these changes
Mar 7, 2024
| amount, | ||
| }: NotificationListItemProps) => { | ||
| const handleClick = () => { | ||
| console.log('clicked', id); |
Contributor
There was a problem hiding this comment.
As a cleanup, lets remove all console.logs once we start integrating these components.
Note to others - these components are not connected in any way inside the extension. But will soon be integrated in followup PRs.
Prithpal-Sooriya
approved these changes
Mar 8, 2024
Contributor
Prithpal-Sooriya
left a comment
There was a problem hiding this comment.
Nice, lets get this first notifications PR in 🎉
Collaborator
Builds ready [aaad20f]
Page Load Metrics (1000 ± 395 ms)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The notifications team is working to introduce a new type of notifications within the extension. These notifications will be listed in a menu where the user can access basic information. By clicking on an single notification, the user will be able to access detailed data.
This PR introduces the necessary components to display individual items within the list and the various types of details for each notification type.
Related issues
Manual testing steps
Currently, the individual components can be tested within Storybook. For each created component, there is a corresponding story for testing and demonstration purposes.
Screenshots/Recordings
Before
After
These are two screenshots taken from the Figma design created by the design team. They represent the notifications list page and the notification detail page.
Notifications list
https://www.figma.com/file/c7GgNw2kScGrVyRGAPhwEd/Notifications?type=design&node-id=1030%3A98661&mode=design&t=MHqDKTFq36ifnkqJ-1
Notification details page
https://www.figma.com/file/c7GgNw2kScGrVyRGAPhwEd/Notifications?type=design&node-id=1030%3A98983&mode=design&t=MHqDKTFq36ifnkqJ-1
Pre-merge author checklist
Pre-merge reviewer checklist