Skip to content

Petnames: code fence removal; experimental toggle#22456

Merged
dbrans merged 71 commits intodevelopfrom
dbrans/petnames-fence
Jan 26, 2024
Merged

Petnames: code fence removal; experimental toggle#22456
dbrans merged 71 commits intodevelopfrom
dbrans/petnames-fence

Conversation

@dbrans
Copy link
Copy Markdown
Contributor

@dbrans dbrans commented Jan 8, 2024

Description

This PR

  • add a toggle to the experimental screen that allows users to enable or disable petnames. This toggle is set to "ON" by default
  • remove the petnames code fence as it's no longer necessary.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1631

Manual testing steps

Note

Use a non-flask build when testing.

Describe Petnames
it should be enabled by default:

  1. Navigate to test dapp.
  2. Click on "Sign" under the heading "Sign Typed Data V3"
  3. Notice the signature confirmation screen uses the petnames name component.

it can be toggled off:

  1. Go to experimental settings
  2. The petnames toggle should be on by default
  3. Switch off the petnames toggle
  4. Navigate to test dapp.
  5. Click on "Sign" under the heading "Sign Typed Data V3"
  6. Notice the signature confirmation screen does not use the petnames name component.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 8, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [15190f9]
Page Load Metrics (878 ± 45 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint951781332612
domContentLoaded105728147
load71310728789445
domInteractive105728147
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 10.08 KiB (0.30%)
  • ui: 2.89 KiB (0.04%)
  • common: 356 Bytes (0.01%)

@dbrans dbrans merged commit ce807ad into develop Jan 26, 2024
@dbrans dbrans deleted the dbrans/petnames-fence branch January 26, 2024 18:19
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2024
@metamaskbot metamaskbot added the release-11.11.0 Issue or pull request that will be included in release 11.11.0 label Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-11.11.0 Issue or pull request that will be included in release 11.11.0 team-confirmations-system-deprecated DEPRECATED: please use "team-confirmations" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants