Skip to content

feat: 22271 add hex data test#22331

Merged
hjetpoluru merged 13 commits intodevelopfrom
feature/22271-add-hex-data-test
Dec 21, 2023
Merged

feat: 22271 add hex data test#22331
hjetpoluru merged 13 commits intodevelopfrom
feature/22271-add-hex-data-test

Conversation

@hjetpoluru
Copy link
Copy Markdown
Contributor

@hjetpoluru hjetpoluru commented Dec 18, 2023 •
edited
Loading

Description

This is an automation test for toggling the hex data. The user should be able to input text via the send transaction feature.

Related issues

Fixes: #22271

Manual testing steps

  1. Go to User settings page
  2. In the advanced tab, there should be toggle for "Show Hex Data"
  3. In the send transaction, verify that the HexData text box appears.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@hjetpoluru hjetpoluru self-assigned this Dec 18, 2023
@hjetpoluru hjetpoluru requested a review from a team as a code owner December 18, 2023 20:18
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 18, 2023 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@hjetpoluru hjetpoluru added e2e-test End to end test for the MetaMask extension team-extension-platform Extension Platform team and removed e2e-test End to end test for the MetaMask extension labels Dec 18, 2023
DDDDDanica
DDDDDanica reviewed Dec 19, 2023
View reviewed changes
DDDDDanica
DDDDDanica reviewed Dec 19, 2023
View reviewed changes
@danjm
Copy link
Copy Markdown
Contributor

danjm commented Dec 19, 2023

You can run yarn lint:changed to determine the lint problems, and they may be fixable with yarn lint:changed:fix

@hjetpoluru
Copy link
Copy Markdown
Contributor Author

hjetpoluru commented Dec 19, 2023

I have read the CLA Document and I hereby sign the CLA

@hjetpoluru
Copy link
Copy Markdown
Contributor Author

hjetpoluru commented Dec 19, 2023

You can run yarn lint:changed to determine the lint problems, and they may be fixable with yarn lint:changed:fix

@hjetpoluru hjetpoluru closed this Dec 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2023
@hjetpoluru hjetpoluru reopened this Dec 19, 2023
@hjetpoluru hjetpoluru force-pushed the feature/22271-add-hex-data-test branch from a30438a to 28db83c Compare December 19, 2023 15:55
@hjetpoluru hjetpoluru force-pushed the feature/22271-add-hex-data-test branch from 5ea59a2 to 77a21e6 Compare December 19, 2023 19:01
@hjetpoluru hjetpoluru force-pushed the feature/22271-add-hex-data-test branch from 486949d to 3ed62f8 Compare December 20, 2023 16:28
@hjetpoluru hjetpoluru requested a review from danjm December 20, 2023 19:08
danjm
danjm approved these changes Dec 21, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I like the way you have structured the code here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Dec 21, 2023

Builds ready [02e2f90]
Page Load Metrics (1305 ± 125 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint982801586230
domContentLoaded10189577134
load84417431305261125
domInteractive10189577134
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@danjm
Copy link
Copy Markdown
Contributor

danjm commented Dec 21, 2023

One other change you should make to this PR is to add a description. Descriptions are important because they serve as a form of documentation, both for code reviewers, but also for people contributing to the code base in the future, in case they need to debug anything or build on top of your work.

@hjetpoluru hjetpoluru merged commit e76e8f6 into develop Dec 21, 2023
@hjetpoluru hjetpoluru deleted the feature/22271-add-hex-data-test branch December 21, 2023 15:50
@metamaskbot metamaskbot added the release-11.9.0 Issue or pull request that will be included in release 11.9.0 label Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@DDDDDanica DDDDDanica Awaiting requested review from DDDDDanica

+1 more reviewer

@danjm danjm danjm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hjetpoluru hjetpoluru

Labels

release-11.9.0 Issue or pull request that will be included in release 11.9.0 team-extension-platform Extension Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add e2e test to validate that the show hex data toggle in settings works

5 participants

@hjetpoluru @danjm @metamaskbot @DDDDDanica @pedronfigueiredo