Description

Cryptocompare reported a spike in API requests. This is the result of incorrectly starting CurrencyRateController polling on MetaMask extension background startup. This PR fixes the issue by removing the logic that was starting CurrencyRateController polling in the constructor.

Related issues

Fixes: #21549

Manual testing steps

1. Open network debug on background.html
2. Restart extension
3. No cryptocompare requests should be seen
4. Open wallet UI
5. One cryptocompare request should be seen
6. Wait 3mins
7. Another cryptocompare request should be seen
8. Close UI
9. Wait 3mins
10. No additional cryptocompare requests should be seen

Screenshots/Recordings

Before

Note the requests made before the UI is open, but that they are stopped after UI is opened then closed for the first time.

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.