Skip to content

Update assets controllers to version 22 - OpenSea V2#22324

Merged
bergeron merged 3 commits intodevelopfrom
brian/opensea-v2
Dec 18, 2023
Merged

Update assets controllers to version 22 - OpenSea V2#22324
bergeron merged 3 commits intodevelopfrom
brian/opensea-v2

Conversation

@bergeron
Copy link
Copy Markdown
Contributor

@bergeron bergeron commented Dec 18, 2023

Description

Updates the assets controllers package to version 22.0.0. This brings in PR 3654 to migrate from OpenSea V1 to V2 API.

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/1841

Manual testing steps

  1. Import a wallet containing NFTs on mainnet
  2. Manually import an NFT owner by the wallet, verify it appears
  3. Enable NFT autodetection in settings, verify the rest of the NFTs appear
  4. Verify descriptions, collection/token images are correct
  5. Send an NFT, verify it works

Screenshots/Recordings

No visible differences

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron requested a review from a team as a code owner December 18, 2023 16:18
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 18, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Dec 18, 2023 •
edited
Loading

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@metamask/assets-controllers 21.0.0...22.0.0 None +1/-0 922 kB metamaskbot

@socket-security
Copy link
Copy Markdown

socket-security bot commented Dec 18, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (50b581d) 67.87% compared to head (5504808) 67.87%.
Report is 1 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #22324   +/-   ##
========================================
  Coverage    67.87%   67.87%           
========================================
  Files         1068     1068           
  Lines        41301    41301           
  Branches     11079    11080    +1     
========================================
  Hits         28030    28030           
  Misses       13271    13271

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DDDDDanica
Copy link
Copy Markdown
Contributor

DDDDDanica commented Dec 18, 2023

Hey @bergeron i want to ask if you will update the usage of v1 api in MM repo as well?
https://github.com/MetaMask/metamask-extension/blob/develop/app/scripts/lib/security-provider-helpers.ts#L81

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Dec 18, 2023

Builds ready [5504808]
Page Load Metrics (1283 ± 128 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint913101977436
domContentLoaded10224797737
load94218181283266128
domInteractive10224797737
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 64 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 2.38 KiB (0.05%)

@bergeron
Copy link
Copy Markdown
Contributor Author

bergeron commented Dec 18, 2023

Hey @bergeron i want to ask if you will update the usage of v1 api in MM repo as well? https://github.com/MetaMask/metamask-extension/blob/develop/app/scripts/lib/security-provider-helpers.ts#L81

Good flag. Looking into this endpoint, but I suspect this V1 might be an internal versioning scheme and not OpenSea's V1.

@bergeron bergeron merged commit b84c2e1 into develop Dec 18, 2023
@bergeron bergeron deleted the brian/opensea-v2 branch December 18, 2023 20:41
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2023
@metamaskbot metamaskbot added the release-11.9.0 Issue or pull request that will be included in release 11.9.0 label Dec 18, 2023
@metamaskbot metamaskbot added release-11.7.3 Issue or pull request that will be included in release 11.7.3 and removed release-11.9.0 Issue or pull request that will be included in release 11.9.0 labels Jan 2, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 2, 2024

Missing release label release-11.7.3 on PR. Adding release label release-11.7.3 on PR and removing other release labels(release-11.9.0), as PR was cherry-picked in branch 11.7.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sahar-fehri sahar-fehri sahar-fehri approved these changes

@DDDDDanica DDDDDanica DDDDDanica approved these changes

@salimtb salimtb Awaiting requested review from salimtb

Assignees

No one assigned

Labels

release-11.7.3 Issue or pull request that will be included in release 11.7.3 team-assets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bergeron @DDDDDanica @metamaskbot @sahar-fehri