Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
d11f2bc to
dfa8638
Compare
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is shell access?This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code. Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
|
EDIT: Actually the networkDidChange update was part of assets-controller 21.0.0, so i'm unsure how this was broken before that EDIT2: I think I understand now. I believe your PR title should be something like |
jiexi
left a comment
There was a problem hiding this comment.
GasFeeController also takes in onNetworkDidChange now
816db90 to
a0d2c12
Compare
|
@metamaskbot update-policies |
|
Policies updated |
jiexi
left a comment
There was a problem hiding this comment.
Looking good. Just minor comments on removing some stale comments. Thank you!
9cd04fc to
7fdf394
Compare
|
REMINDER: Please update the squashed commit message to mention the bump of |
7fdf394 to
1f539d2
Compare
1f539d2 to
00abdec
Compare
mcmire
left a comment
There was a problem hiding this comment.
Looks great! Thank you for taking care of this.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #22295 +/- ##
===========================================
- Coverage 67.96% 67.94% -0.02%
===========================================
Files 1067 1067
Lines 41274 41290 +16
Branches 11082 11087 +5
===========================================
+ Hits 28050 28054 +4
- Misses 13224 13236 +12 ☔ View full report in Codecov by Sentry. |
Builds ready [00abdec]
Page Load Metrics (1219 ± 130 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
|
Missing release label release-11.7.3 on PR. Adding release label release-11.7.3 on PR and removing other release labels(release-11.9.0), as PR was cherry-picked in branch 11.7.3. |
Description
When Using latest version of core, the UI cannot display on the home page the user's fiat token balance.
This PR fixes the instantiation of the tokenRatesController.
This was tested by building core with assets-controllers version 21.0.0.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
With the current versions you would have errors loading the extension
After
Loads successfully and home page displays token fiat balance
Pre-merge author checklist
Pre-merge reviewer checklist