Skip to content

UX: Show Total Account Balances#22186

Merged
darkwing merged 33 commits intodevelopfrom
release-asset-group
Feb 14, 2024
Merged

UX: Show Total Account Balances#22186
darkwing merged 33 commits intodevelopfrom
release-asset-group

Conversation

@darkwing
Copy link
Copy Markdown
Contributor

@darkwing darkwing commented Dec 6, 2023 •
edited
Loading

Description

Shows total account balances in the Accounts Menu and home screen overview.

Related issues

Fixes:

Manual testing steps

  1. Open the account list -- see account totals
  2. See the same total on the home overview of each account

Screenshots/Recordings

Before

SCR-20231206-kihi

After

SCR-20231206-kijz

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner December 6, 2023 17:22
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 6, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Dec 6, 2023

Builds ready [b7db1dd]
Page Load Metrics (1310 ± 43 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint92169106178
domContentLoaded10431673
load1084151113108943
domInteractive10431673
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 326 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 6, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (391e9e7) 68.55% compared to head (2e083a8) 68.55%.
Report is 2 commits behind head on develop.

Files Patch % Lines
ui/components/app/wallet-overview/eth-overview.js 87.50% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #22186   +/-   ##
========================================
  Coverage    68.55%   68.55%           
========================================
  Files         1088     1088           
  Lines        42907    42916    +9     
  Branches     11415    11413    -2     
========================================
+ Hits         29411    29418    +7     
- Misses       13496    13498    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

NidhiKJha
NidhiKJha previously approved these changes Dec 8, 2023
View reviewed changes
vthomas13
vthomas13 previously approved these changes Dec 11, 2023
View reviewed changes
@darkwing darkwing dismissed stale reviews from vthomas13 and NidhiKJha via 9688179 December 11, 2023 23:17
vthomas13
vthomas13 previously approved these changes Dec 12, 2023
View reviewed changes
@darkwing darkwing mentioned this pull request Dec 12, 2023
Closed
13 tasks
@darkwing darkwing force-pushed the release-asset-group branch from dada77d to 663ff79 Compare December 12, 2023 20:58
@darkwing darkwing changed the title UX: Release AvatarGroup for Account Menu UX: Release AvatarGroup for Account Menu, Show Total Account Balances Dec 13, 2023
@darkwing darkwing changed the title UX: Release AvatarGroup for Account Menu, Show Total Account Balances UX: Show Total Account Balances Dec 13, 2023
@darkwing darkwing force-pushed the release-asset-group branch 3 times, most recently from d742032 to 277d00c Compare December 19, 2023 20:34
@NidhiKJha NidhiKJha force-pushed the release-asset-group branch 2 times, most recently from e20ef46 to 6d0707a Compare February 5, 2024 13:01
vthomas13
vthomas13 previously approved these changes Feb 5, 2024
View reviewed changes
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 6, 2024

Builds ready [8ec6020]
Page Load Metrics (803 ± 31 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint92149113147
domContentLoaded9451884
load71410178036431
domInteractive9451884
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 131 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@darkwing darkwing added needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. and removed needs-ux-ds-review labels Feb 7, 2024
@hesterbruikman hesterbruikman added the team-core-extension-ux Core Extension UX team label Feb 7, 2024
@NidhiKJha NidhiKJha force-pushed the release-asset-group branch from 1d28374 to 6dcdd50 Compare February 8, 2024 17:00
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 8, 2024

Builds ready [3c71afc]
Page Load Metrics (739 ± 18 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7813098136
domContentLoaded9311753
load6898407393718
domInteractive9311753
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 131 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

vthomas13
vthomas13 previously approved these changes Feb 8, 2024
View reviewed changes
NidhiKJha
NidhiKJha previously approved these changes Feb 8, 2024
View reviewed changes
darkwing
darkwing commented Feb 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@darkwing darkwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow @NidhiKJha , you really brought this home! Just one issue:

We aren't respecting the "Show conversions on test networks" setting, always showing fiat for test networks:

SCR-20240208-qwhf SCR-20240208-qwji

Other than that, this is good to go!

@NidhiKJha NidhiKJha dismissed stale reviews from vthomas13 and themself via 84ffe7e February 13, 2024 08:30
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 14, 2024

Builds ready [2e083a8]
Page Load Metrics (930 ± 25 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1253821904923
domContentLoaded992432813
load84510879305225
domInteractive992432813
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 762 Bytes (0.01%)
  • common: 40 Bytes (0.00%)

@darkwing darkwing merged commit 558f32f into develop Feb 14, 2024
@darkwing darkwing deleted the release-asset-group branch February 14, 2024 14:48
@github-actions github-actions bot locked and limited conversation to collaborators Feb 14, 2024
@metamaskbot metamaskbot added the release-11.12.0 Issue or pull request that will be included in release 11.12.0 label Feb 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NidhiKJha NidhiKJha NidhiKJha approved these changes

+1 more reviewer

@vthomas13 vthomas13 vthomas13 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NidhiKJha NidhiKJha

Labels

needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-11.12.0 Issue or pull request that will be included in release 11.12.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@darkwing @metamaskbot @vthomas13 @NidhiKJha @gauthierpetetin @hesterbruikman