Skip to content

fix(22139): change the header key to coinGecko calls#22175

Merged
DDDDDanica merged 1 commit intodevelopfrom
fix/coingecko-header
Dec 5, 2023
Merged

fix(22139): change the header key to coinGecko calls#22175
DDDDDanica merged 1 commit intodevelopfrom
fix/coingecko-header

Conversation

@DDDDDanica
Copy link
Copy Markdown
Contributor

@DDDDDanica DDDDDanica commented Dec 5, 2023 •
edited
Loading

Description

Screenshot 2023-12-05 at 17 07 03

Modify headers in request for CoinGecko inside the patches and swap util

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@DDDDDanica DDDDDanica self-assigned this Dec 5, 2023
@DDDDDanica DDDDDanica requested a review from a team as a code owner December 5, 2023 17:06
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 5, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Dec 5, 2023

Builds ready [9e75dbc]
Page Load Metrics (1190 ± 53 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint91168106178
domContentLoaded15301832
load10241358119011053
domInteractive15301832
Bundle size diffs [🚀 Bundle size reduced!]
  • background: 0 Bytes (0.00%)
  • ui: -2 Bytes (-0.00%)
  • common: -2 Bytes (-0.00%)

@danjm danjm added the release-blocker This bug is blocking the next release label Dec 5, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 5, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (64d80b2) 67.71% compared to head (9e75dbc) 67.71%.
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #22175   +/-   ##
========================================
  Coverage    67.71%   67.71%           
========================================
  Files         1052     1052           
  Lines        40874    40874           
  Branches     10951    10951           
========================================
  Hits         27677    27677           
  Misses       13197    13197

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DDDDDanica DDDDDanica merged commit 7a1aa46 into develop Dec 5, 2023
@DDDDDanica DDDDDanica deleted the fix/coingecko-header branch December 5, 2023 18:10
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2023
@metamaskbot metamaskbot added the release-11.8.0 Issue or pull request that will be included in release 11.8.0 label Dec 5, 2023
@metamaskbot metamaskbot added release-11.7.3 Issue or pull request that will be included in release 11.7.3 and removed release-11.8.0 Issue or pull request that will be included in release 11.8.0 labels Jan 2, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jan 2, 2024

Missing release label release-11.7.3 on PR. Adding release label release-11.7.3 on PR and removing other release labels(release-11.8.0), as PR was cherry-picked in branch 11.7.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@shane-t shane-t shane-t approved these changes

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

Assignees

@DDDDDanica DDDDDanica

Labels

release-11.7.3 Issue or pull request that will be included in release 11.7.3 release-blocker This bug is blocking the next release team-extension-platform Extension Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DDDDDanica @metamaskbot @shane-t @pedronfigueiredo @danjm