Bump @metamask/assets-controllers version to v19.0.0#22117
Merged
Bump @metamask/assets-controllers version to v19.0.0#22117
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
Contributor
Author
|
@metamaskbot update-policies |
Collaborator
|
Policies updated |
2851bab to
0ae5dbb
Compare
adonesky1
commented
Dec 1, 2023
| it('should enable approval for a third party address to manage all ERC1155 token', async function () { | ||
| const expectedMessageTitle = | ||
| 'Allow access to and transfer all of your NFTs from this collection?'; | ||
| 'Allow access to and transfer all of your NFTs from ERC1155?'; |
Contributor
Author
There was a problem hiding this comment.
version 19.0.0 contains a change where we're reading the contract level asset name for ERC1155s. The test-dapp contracts happen to have a name "ERC1155"
Member
There was a problem hiding this comment.
worth leaving a comment? This may cause confusion for others in the future
Contributor
Author
There was a problem hiding this comment.
I've added a comment on line 133
BelfordZ
previously approved these changes
Dec 1, 2023
Collaborator
Builds ready [25c465f]
Page Load Metrics (1224 ± 49 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #22117 +/- ##
========================================
Coverage 67.78% 67.78%
========================================
Files 1053 1053
Lines 40969 40969
Branches 10971 10971
========================================
Hits 27770 27770
Misses 13199 13199 ☔ View full report in Codecov by Sentry. |
jiexi
approved these changes
Dec 1, 2023
Member
jiexi
left a comment
There was a problem hiding this comment.
LGTM. feel free to ignore the nit above
Collaborator
Builds ready [3a0a351]
Page Load Metrics (1154 ± 71 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
|
Missing release label release-11.7.3 on PR. Adding release label release-11.7.3 on PR and removing other release labels(release-11.8.0), as PR was cherry-picked in branch 11.7.3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump @metamask/assets-controllers version to v19.0.0