Skip to content

Implement routing for new confirmation components#21970

Merged
jpuri merged 29 commits intodevelopfrom
confirm_routing
Dec 13, 2023
Merged

Implement routing for new confirmation components#21970
jpuri merged 29 commits intodevelopfrom
confirm_routing

Conversation

@jpuri
Copy link
Copy Markdown
Contributor

@jpuri jpuri commented Nov 23, 2023 •
edited
Loading

Description

Implement routing for new conformation pages.

Related issues

Fixes: #21277

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • [] I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added team-confirmations-secure-ux-deprecated DEPRECATED: please use "team-confirmations" instead needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) confirmation-redesign labels Nov 23, 2023
@jpuri jpuri requested a review from a team as a code owner November 23, 2023 13:27
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 23, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bschorchit bschorchit added team-confirmations-secure-ux-PR PRs from the confirmations team and removed team-confirmations-secure-ux-deprecated DEPRECATED: please use "team-confirmations" instead labels Nov 23, 2023
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 24, 2023 •
edited
Loading

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (653962c) 67.80% compared to head (ae165ce) 67.86%.
Report is 2 commits behind head on develop.

Files Patch % Lines
ui/hooks/confirm/useCurrentConfirmation.ts 83.33% 4 Missing ⚠️
ui/pages/confirm/confirm.tsx 25.00% 3 Missing ⚠️
ui/hooks/confirm/syncConfirmPath.ts 88.89% 1 Missing ⚠️
...nfirm-transaction/confirm-transaction.component.js 66.67% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #21970      +/-   ##
===========================================
+ Coverage    67.80%   67.86%   +0.06%     
===========================================
  Files         1055     1058       +3     
  Lines        40889    40947      +58     
  Branches     10977    10989      +12     
===========================================
+ Hits         27721    27785      +64     
+ Misses       13168    13162       -6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Nov 24, 2023

Builds ready [1281997]
Page Load Metrics (626 ± 289 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint88153106189
domContentLoaded7513896199
load831777626602289
domInteractive7513796199
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 1.96 KiB (0.03%)
  • common: 0 Bytes (0.00%)

digiwand
digiwand reviewed Nov 29, 2023
View reviewed changes
segun
segun reviewed Nov 29, 2023
View reviewed changes
@jpuri @digiwand
Update ui/ducks/confirm/confirm.test.js
5aeacef 
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
jpuri and others added 3 commits November 29, 2023 18:46
@jpuri @digiwand
Update ui/hooks/confirm/setCurrentConfirmation.ts
89aba70 
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
@jpuri
update
70f0133
@jpuri
Merge branch 'confirm_routing' of github.com:MetaMask/metamask-extens…
96faa1c 
…ion into confirm_routing
@jpuri jpuri requested review from digiwand and segun November 29, 2023 13:21
Base automatically changed from confirm_layout to develop November 30, 2023 06:40
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Nov 30, 2023

Builds ready [acde770]
Page Load Metrics (1295 ± 96 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint881761213115
domContentLoaded105727168
load9981724129519996
domInteractive105727168
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 1.96 KiB (0.03%)
  • common: 0 Bytes (0.00%)

digiwand
digiwand previously approved these changes Dec 1, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@digiwand digiwand left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I think we just need to update one of the tests

edit: oops. I meant to leave a comment review not approve here. feel free to reach out if there are any questions about the review

segun
segun previously approved these changes Dec 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@segun segun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some comments by Ariella, otherwise good to go.

@digiwand digiwand mentioned this pull request Dec 7, 2023
Closed
13 tasks
@jpuri jpuri dismissed stale reviews from segun and digiwand via 45a7c26 December 11, 2023 08:57
jpuri and others added 4 commits December 11, 2023 14:27
@jpuri @digiwand
Update ui/selectors/index.js
45a7c26 
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
@jpuri @digiwand
Update ui/hooks/confirm/syncConfirmPath.test.ts
8bcd6dd 
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
@jpuri @digiwand
Update ui/hooks/confirm/setCurrentConfirmation.test.ts
fd8c6f9 
Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>
@jpuri
Merge branch 'develop' into confirm_routing
596ad3f
@jpuri jpuri requested review from digiwand and segun December 11, 2023 10:18
@jpuri jpuri requested a review from kumavis as a code owner December 11, 2023 10:31
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Dec 11, 2023

Builds ready [ae165ce]
Page Load Metrics (1384 ± 139 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint892811545928
domContentLoaded9180405627
load98720191384289139
domInteractive9180405627
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 1.96 KiB (0.03%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri merged commit dd00145 into develop Dec 13, 2023
@jpuri jpuri deleted the confirm_routing branch December 13, 2023 05:19
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 13, 2023
@metamaskbot metamaskbot added the release-11.9.0 Issue or pull request that will be included in release 11.9.0 label Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@kumavis kumavis Awaiting requested review from kumavis kumavis is a code owner

2 more reviewers

@segun segun segun approved these changes

@digiwand digiwand digiwand approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

confirmation-redesign release-11.9.0 Issue or pull request that will be included in release 11.9.0 team-confirmations-secure-ux-PR PRs from the confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement new routing for signature request pages

5 participants

@jpuri @metamaskbot @segun @digiwand @bschorchit