Skip to content

fix: JSDoc in preferences-controller#21890

Merged
gantunesr merged 5 commits intodevelopfrom
fix/docs-preferences
Dec 21, 2023
Merged

fix: JSDoc in preferences-controller#21890
gantunesr merged 5 commits intodevelopfrom
fix/docs-preferences

Conversation

@gantunesr
Copy link
Copy Markdown
Member

@gantunesr gantunesr commented Nov 20, 2023

Description

Small correction in the preferences controller JSDocs, the method syncAddresses indicates that all operations are synchronous and therefore it does not return a promise

Related issues

Not applicable

Manual testing steps

Not applicable

Screenshots/Recordings

Before

Not applicable

After

Not applicable

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gantunesr gantunesr added team-accounts-framework Accounts team needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Nov 20, 2023
@gantunesr gantunesr marked this pull request as ready for review November 20, 2023 13:50
@gantunesr gantunesr requested a review from a team as a code owner November 20, 2023 13:50
@gantunesr gantunesr mentioned this pull request Nov 21, 2023
Merged
14 tasks
@codecov
Copy link
Copy Markdown

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ca07ce5) 68.01% compared to head (55c61f4) 68.00%.
Report is 2 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #21890      +/-   ##
===========================================
- Coverage    68.01%   68.00%   -0.01%     
===========================================
  Files         1075     1075              
  Lines        41574    41574              
  Branches     11180    11180              
===========================================
- Hits         28273    28270       -3     
- Misses       13301    13304       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Dec 21, 2023

Builds ready [55c61f4]
Page Load Metrics (1339 ± 168 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint823841778340
domContentLoaded9231586632
load76919091339349168
domInteractive9231586632
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@gantunesr gantunesr merged commit bd2a23a into develop Dec 21, 2023
@gantunesr gantunesr deleted the fix/docs-preferences branch December 21, 2023 16:34
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Dec 21, 2023
@metamaskbot metamaskbot added the release-11.9.0 Issue or pull request that will be included in release 11.9.0 label Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@owencraston owencraston owencraston approved these changes

+1 more reviewer

@k-g-j k-g-j k-g-j approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.9.0 Issue or pull request that will be included in release 11.9.0 team-accounts-framework Accounts team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gantunesr @metamaskbot @owencraston @k-g-j