Skip to content

devDeps: @storybook/test-runner@^0.10.0->^0.14.0#21767

Merged
HowardBraham merged 2 commits intoMetaMask:developfrom
legobeat:devDeps-storybook-test-runner
Jan 31, 2024
Merged

devDeps: @storybook/test-runner@^0.10.0->^0.14.0#21767
HowardBraham merged 2 commits intoMetaMask:developfrom
legobeat:devDeps-storybook-test-runner

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Nov 9, 2023 •
edited
Loading

Description

  • Update @storybook/test-runner to latest
    • Changes
    • Uses Jest v29 (like metamask-extension itself already does) instead of Jest v28

Related issues

N/A

Manual testing steps

Run storybook tests

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 9, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Nov 9, 2023
@legobeat legobeat marked this pull request as ready for review November 9, 2023 04:41
@legobeat legobeat requested a review from a team as a code owner November 9, 2023 04:41
@legobeat legobeat added the dependencies Pull requests that update a dependency file label Nov 9, 2023
@socket-security
Copy link
Copy Markdown

socket-security bot commented Nov 9, 2023 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@jest/create-cache-key-function@29.7.0 environment, filesystem +15 4.54 MB simenb
npm/@storybook/test-runner@0.14.1 environment Transitive: eval, filesystem, network, shell, unsafe +467 663 MB shilman
npm/@swc/jest@0.2.31 filesystem Transitive: environment, shell +30 406 MB kdy1
npm/jest-playwright-preset@3.0.1 environment, filesystem Transitive: eval, network, shell, unsafe +295 438 MB mxschmitt
npm/jsonc-parser@3.2.1 None 0 210 kB vscode-bot

🚮 Removed packages: npm/@jest/console@28.1.3, npm/@jest/core@28.1.3, npm/@jest/reporters@28.1.3, npm/@jest/test-result@28.1.3, npm/@storybook/test-runner@0.10.0, npm/diff-sequences@28.1.1, npm/istanbul-lib-instrument@5.2.1, npm/jest-changed-files@28.1.3, npm/jest-circus@28.1.3, npm/jest-cli@28.1.3, npm/jest-config@28.1.3, npm/jest-environment-node@28.1.3, npm/jest-message-util@28.1.3, npm/jest-playwright-preset@2.0.0, npm/jest-resolve-dependencies@28.1.3, npm/jest-resolve@28.1.3, npm/jest-runner@28.1.3, npm/jest-runtime@28.1.3, npm/jest-snapshot@28.1.3, npm/jest-validate@28.1.3, npm/jest-watcher@28.1.3, npm/jest-worker@28.1.3, npm/pretty-format@28.1.3, npm/supports-hyperlinks@2.3.0, npm/terminal-link@2.1.1

View full report↗︎

@socket-security
Copy link
Copy Markdown

socket-security bot commented Nov 9, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/@jest/create-cache-key-function@29.7.0, npm/jsonc-parser@3.2.1

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@legobeat legobeat force-pushed the devDeps-storybook-test-runner branch from efdb76e to 439f5b7 Compare November 9, 2023 04:57
@legobeat legobeat requested review from a team as code owners November 9, 2023 04:57
@legobeat
Copy link
Copy Markdown
Contributor Author

legobeat commented Nov 9, 2023 

@SocketSecurity ignore @storybook/test-runner@0.14.0

shell access ok

@legobeat
Copy link
Copy Markdown
Contributor Author

legobeat commented Nov 9, 2023 

@SocketSecurity ignore @jest/create-cache-key-function@27.5.1

no readme ok

@legobeat legobeat added the team-application-security Application security team label Nov 9, 2023
@legobeat legobeat force-pushed the devDeps-storybook-test-runner branch from 439f5b7 to 7cf69ec Compare November 9, 2023 06:18
@legobeat legobeat force-pushed the devDeps-storybook-test-runner branch from 7cf69ec to 35d0edd Compare December 25, 2023 23:05
@legobeat legobeat force-pushed the devDeps-storybook-test-runner branch 2 times, most recently from d83ef59 to 9660a7a Compare January 15, 2024 10:50
@legobeat legobeat force-pushed the devDeps-storybook-test-runner branch 2 times, most recently from 801d706 to 6696be0 Compare January 18, 2024 15:40
@legobeat
Copy link
Copy Markdown
Contributor Author

legobeat commented Jan 18, 2024 

@SocketSecurity ignore @storybook/test-runner@0.14.1

shell access ok

@legobeat legobeat force-pushed the devDeps-storybook-test-runner branch 2 times, most recently from 4762316 to fedef91 Compare January 22, 2024 11:10
@legobeat
Copy link
Copy Markdown
Contributor Author

legobeat commented Jan 22, 2024 

@SocketSecurity ignore npm/@jest/create-cache-key-function@29.7.0

no author data ok

@legobeat legobeat force-pushed the devDeps-storybook-test-runner branch from fedef91 to f51abff Compare January 26, 2024 13:10
@legobeat
Copy link
Copy Markdown
Contributor Author

legobeat commented Jan 26, 2024 

@SocketSecurity ignore npm/jsonc-parser@3.2.1

new author ok

@legobeat legobeat requested a review from a team January 29, 2024 10:22
@legobeat legobeat force-pushed the devDeps-storybook-test-runner branch from f51abff to 515a023 Compare January 30, 2024 11:20
@legobeat legobeat force-pushed the devDeps-storybook-test-runner branch from 515a023 to 4a85389 Compare January 31, 2024 09:18
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (862617d) 68.11% compared to head (4a85389) 68.11%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #21767      +/-   ##
===========================================
- Coverage    68.11%   68.11%   -0.00%     
===========================================
  Files         1087     1087              
  Lines        42794    42794              
  Branches     11381    11381              
===========================================
- Hits         29148    29147       -1     
- Misses       13646    13647       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@legobeat legobeat force-pushed the devDeps-storybook-test-runner branch from 4a85389 to 9c08ae9 Compare January 31, 2024 15:51
@legobeat legobeat force-pushed the devDeps-storybook-test-runner branch from 9c08ae9 to b3ada42 Compare January 31, 2024 18:30
@HowardBraham HowardBraham merged commit c1a25ec into MetaMask:develop Jan 31, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2024
@legobeat legobeat deleted the devDeps-storybook-test-runner branch January 31, 2024 20:38
@metamaskbot metamaskbot added the release-11.11.0 Issue or pull request that will be included in release 11.11.0 label Feb 17, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 17, 2024

No release label on PR. Adding release label release-11.11.0 on PR, as PR was added to branch 11.11.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidmurdoch davidmurdoch davidmurdoch approved these changes

@HowardBraham HowardBraham HowardBraham approved these changes

@georgewrmarshall georgewrmarshall Awaiting requested review from georgewrmarshall

@DDDDDanica DDDDDanica Awaiting requested review from DDDDDanica

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file INVALID-PR-TEMPLATE PR's body doesn't match template release-11.11.0 Issue or pull request that will be included in release 11.11.0 team-application-security Application security team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@legobeat @metamaskbot @davidmurdoch @HowardBraham