Skip to content

Bump @metamask/network-controller to 15.1.0#21668

Merged
jiexi merged 9 commits intodevelopfrom
jl/bump-network-controller-15.1.0
Nov 6, 2023
Merged

Bump @metamask/network-controller to 15.1.0#21668
jiexi merged 9 commits intodevelopfrom
jl/bump-network-controller-15.1.0

Conversation

@jiexi
Copy link
Copy Markdown
Member

@jiexi jiexi commented Nov 2, 2023 •
edited
Loading

Description

  • Bump @metamask/network-controller to 15.1.0
  • Replace eth-query with @metamask/eth-query
  • Bump @metamask/eth-query to 3.0.1

Needed for bumping @metamask/assets-controller to 18.0.0 from 16

Related issues

See: #21549

Manual testing steps

Nothing should change for the end user

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 2, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Nov 2, 2023 •
edited
Loading

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: @metamask/network-controller@14.0.0

@jiexi jiexi added the team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead label Nov 2, 2023
@jiexi
Copy link
Copy Markdown
Member Author

jiexi commented Nov 2, 2023

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Nov 2, 2023

Policies updated

@jiexi jiexi mentioned this pull request Nov 2, 2023
Merged
13 tasks
@jiexi
Copy link
Copy Markdown
Member Author

jiexi commented Nov 2, 2023

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Nov 2, 2023

Policies updated

@socket-security
Copy link
Copy Markdown

socket-security bot commented Nov 3, 2023 •
edited
Loading

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

@adonesky1 adonesky1 force-pushed the jl/bump-network-controller-15.1.0 branch from a0938f2 to 9141e9b Compare November 3, 2023 17:43
@jiexi
Copy link
Copy Markdown
Member Author

jiexi commented Nov 3, 2023

@metamaskbot update-policies

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Nov 3, 2023

No policy changes

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 6, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a8a6d0a) 68.70% compared to head (527ffe8) 68.70%.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #21668   +/-   ##
========================================
  Coverage    68.70%   68.70%           
========================================
  Files         1042     1042           
  Lines        41572    41572           
  Branches     11097    11097           
========================================
  Hits         28560    28560           
  Misses       13012    13012
Files Coverage Δ
app/scripts/lib/account-tracker.js 50.97% <100.00%> (ø)
app/scripts/lib/transaction/metrics.ts 66.08% <100.00%> (ø)
app/scripts/metamask-controller.js 54.96% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Nov 6, 2023

Builds ready [2420ffe]
Page Load Metrics (337 ± 232 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint89124103126
domContentLoaded7011492136
load841415337483232
domInteractive7011492136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 63.01 KiB (1.57%)
  • ui: 30 Bytes (0.00%)
  • common: 4 Bytes (0.00%)

@jiexi jiexi marked this pull request as ready for review November 6, 2023 21:26
@jiexi jiexi requested review from a team as code owners November 6, 2023 21:26
adonesky1
adonesky1 approved these changes Nov 6, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adonesky1 adonesky1 self-requested a review November 6, 2023 21:40
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Nov 6, 2023

Builds ready [527ffe8]
Page Load Metrics (572 ± 294 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint8112895136
domContentLoaded6312583178
load751630572611294
domInteractive6312583178
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 63.01 KiB (1.57%)
  • ui: 30 Bytes (0.00%)
  • common: 4 Bytes (0.00%)

@jiexi jiexi merged commit 313d0c2 into develop Nov 6, 2023
@jiexi jiexi deleted the jl/bump-network-controller-15.1.0 branch November 6, 2023 22:04
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2023
@metamaskbot metamaskbot added the release-11.6.0 Issue or pull request that will be included in release 11.6.0 label Nov 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@adonesky1 adonesky1 Awaiting requested review from adonesky1

1 more reviewer

@BelfordZ BelfordZ BelfordZ approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.6.0 Issue or pull request that will be included in release 11.6.0 team-wallet-api-platform-deprecated DEPRECATED: please use "team-wallet-integrations" instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jiexi @metamaskbot @BelfordZ @adonesky1