feat: update selectors to include internal accounts#21554
Merged
plasmacorral merged 76 commits intodevelopfrom Dec 19, 2023
Merged
feat: update selectors to include internal accounts#21554plasmacorral merged 76 commits intodevelopfrom
plasmacorral merged 76 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
Contributor
|
https://airgap.it/ can be used to replicate this if a Keystone device isn't available @k-g-j |
…tps://github.com/MetaMask/metamask-extension into feat/update-selectors-to-include-internal-accounts
f46249b
Member
|
@plasmacorral @AlexJupiter this is fixed in the latest commit |
k-g-j
previously approved these changes
Dec 18, 2023
b02f424 to
7f5ffd6
Compare
owencraston
approved these changes
Dec 19, 2023
Collaborator
Builds ready [936937f]
Page Load Metrics (1492 ± 114 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
k-g-j
approved these changes
Dec 19, 2023
Contributor
|
Manually tested chrome 117.0.5938.92 and firefox 120.0.1 and migrating from 11.5.2. Tested imported, Ledger, Trezor, QR, Lattice and Snap accounts with no remaining issues. Tests included NFT details, Account selection, Account connection, signature requests, transactions/activity detail, wallet overview, and editing approvals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, MetaMask faces tight coupling between its UI and the keyring-controller. The UI heavily relies on the keyring-controller's state while also amalgamating information from various sources, such as preferences and balances.
However, this approach presents some challenges. The keyring-controller must be aware of the UI's limitations, like the need for instant account list provision to avoid lag. Moreover, it takes on the responsibility of adding metadata to accounts, such as the associated keyring type, required for displaying account details.
To address these issues, the introduction of the accounts-controller comes into play as a new abstraction layer between the UI and the keyring-controller. This separation of responsibilities allows the keyring-controller to focus on two main tasks:
This PR creates new selectors for Internal Accounts and and updates some ui elements to use the selectors.
Depends on:
#21437
Related issues
Resolves https://github.com/MetaMask/accounts-planning/issues/136
Manual testing steps
Screenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist