Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
60b9553 to
733389d
Compare
733389d to
c94c60f
Compare
13 tasks
Contributor
|
This has been unblocked with the conclusion of the security audit ✅ |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #21436 +/- ##
===========================================
+ Coverage 67.64% 67.71% +0.07%
===========================================
Files 1052 1052
Lines 40640 40598 -42
Branches 10919 10917 -2
===========================================
- Hits 27488 27487 -1
+ Misses 13152 13111 -41 ☔ View full report in Codecov by Sentry. |
blackdevelopa
previously approved these changes
Nov 30, 2023
segun
previously approved these changes
Dec 1, 2023
seaona
reviewed
Dec 4, 2023
| }) | ||
| .thenCallback(() => { | ||
| return { | ||
| statusCode: 500, |
Member
There was a problem hiding this comment.
For getting the Failed Validation warning with the new ppom version, we need a failed response from the RPC.
Before, only using an account with 0 balance was sufficient, but now, this situation won't trigger the Failed Validation, since the transaction will revert - so it's considered Benign and no warning is shown. That's why the test was failing
Collaborator
Builds ready [854a2f1]
Page Load Metrics (1192 ± 69 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
segun
approved these changes
Dec 5, 2023
cryptotavares
approved these changes
Dec 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR Updated
@blockaid/ppom-releasedependency and also updatesppom.jsManual testing steps
_1. Run extension
_2. Go to test dapp and send a malicious confirmation request
_3. Ensure that confirmation page shows blockaid error
Related issues
Fixes #???
Pre-merge author checklist
Pre-merge reviewer checklist