Conversation
Member
Author
|
Idk if we have this event on mobile but we should remove it there as well. |
legobeat
approved these changes
Aug 3, 2023
Codecov Report
@@ Coverage Diff @@
## develop #20376 +/- ##
========================================
Coverage 68.78% 68.78%
========================================
Files 994 994
Lines 38625 38623 -2
Branches 10367 10367
========================================
- Hits 26565 26564 -1
+ Misses 12060 12059 -1
|
Collaborator
Builds ready [1ed1afd]
Page Load Metrics (1586 ± 50 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
FrederikBolding
approved these changes
Aug 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Removes the
Website Accessed window.web3 Shimevent from themetamask_logWeb3ShimUsageRPC method implementation. The method itself displays an alert to the user if a website attempts to access thewindow.web3shim, which we replaced the original, functionalwindow.web3object with after said object was removed. This seems potentially useful, because we still get 5-star reviews on the legacy web3 extension.The associated metrics event, on the other hand, is useless. It is rife with false positives, and doesn't tell us anything that we can't learn from download data for the legacy web3 extension. It's time to get rid of it.
There are no associated tests for this functionality.
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.