Update Text import paths: /pages#20117
Merged
garrettbear merged 2 commits intodevelopfrom Jul 20, 2023
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Comment on lines
+21
to
-26
| Text, | ||
| ///: END:ONLY_INCLUDE_IN | ||
| IconName, | ||
| IconSize, | ||
| } from '../../components/component-library'; | ||
| ///: BEGIN:ONLY_INCLUDE_IN(snaps) | ||
| import { Text } from '../../components/component-library/text/deprecated'; |
Contributor
Author
There was a problem hiding this comment.
Making sure the import is still only included in snaps. This is the only other file in the codebase and it is outside of /pages but thought it would be ok to include in this PR
Collaborator
Builds ready [59cb054]
Page Load Metrics (1518 ± 53 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #20117 +/- ##
========================================
Coverage 69.34% 69.34%
========================================
Files 986 986
Lines 37299 37299
Branches 10011 10011
========================================
Hits 25864 25864
Misses 11435 11435
|
DDDDDanica
approved these changes
Jul 20, 2023
hmalik88
approved these changes
Jul 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Currently, there are deprecated instances of the
Textcomponent that use the JavaScript version of theBoxcomponent. This PR updates those deprecated import paths to the new component in theui/components/pagesfolder as well as snapshots. There should be no visual or component API difference between the two. Just className changes which will touch many snapshotsSearching for path of the deprecated Text import paths returns no results 🥳
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.