Update Text import paths: /ui#20076
Merged
garrettbear merged 2 commits intodevelopfrom Jul 19, 2023
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
b704a97 to
ccafb3a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #20076 +/- ##
===========================================
- Coverage 69.46% 69.46% -0.01%
===========================================
Files 992 992
Lines 37452 37452
Branches 10042 10042
===========================================
- Hits 26015 26013 -2
- Misses 11437 11439 +2
|
Collaborator
Builds ready [ccafb3a]
Page Load Metrics (1403 ± 27 ms)
Bundle size diffs
|
garrettbear
previously approved these changes
Jul 18, 2023
Contributor
Author
There was a problem hiding this comment.
this shouldn't be passed to the html element
Contributor
Author
There was a problem hiding this comment.
Use Box from component-library
Contributor
Author
There was a problem hiding this comment.
Use Box from component-library
cd83d39 to
661641f
Compare
Contributor
Author
There was a problem hiding this comment.
No visual regressions
Contributor
Author
There was a problem hiding this comment.
No visual regressions
Contributor
Author
There was a problem hiding this comment.
No visual regressions
Contributor
Author
There was a problem hiding this comment.
![Uploading Screenshot 2023-07-18 at 3.17.46 PM.png…]()
40c6f62 to
23696d1
Compare
Contributor
Author
There was a problem hiding this comment.
removes prop being passed down to html attribute
Contributor
Author
There was a problem hiding this comment.
removes prop being passed down to html attribute
173a3e6 to
05f6764
Compare
Collaborator
Builds ready [875ae63]
Page Load Metrics (1563 ± 103 ms)
Bundle size diffs
|
DDDDDanica
reviewed
Jul 19, 2023
DDDDDanica
approved these changes
Jul 19, 2023
Mrtenz
approved these changes
Jul 19, 2023
garrettbear
approved these changes
Jul 19, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Currently, there are deprecated instances of the
Textcomponent that use the JavaScript version of theBoxcomponent. This PR updates those deprecated import paths to the new component in theui/components/uifolder as well as snapshots. There should be no visual or component API difference between the two. Just className changes which will touch many snapshotsScreenshots/Screencaps
I have added Before/After screencasts to ensure no visual regressions have occurred to components with some significant updates other than snapshot updates in the code comments
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.