Update Text import paths: /institutional by georgewrmarshall · Pull Request #20064 · MetaMask/metamask-extension

georgewrmarshall · 2023-07-18T00:22:46Z

Explanation

Currently, there are deprecated instances of the Text component that use the JavaScript version of the Box component. This PR updates those deprecated import paths to the new component in the ui/components/institutional folder as well as snapshots

Part of Update deprecated Text import paths #19986

Dependency: Updating Text component to use TS Box #19949

Screenshots/Screencaps

I have added Before/After screencasts to ensure no visual regressions have occurred to components with some significant updates other than snapshot updates in the code comments

Manual Testing Steps

Go to the latest build of storybook in this PR
Check all components don't have visual regressions against the hosted storybook GitHub page

Pre-merge author checklist

I've clearly explained:
- What problem this PR is solving
- How this problem was solved
- How reviewers can test my changes
Sufficient automated test coverage has been added

Pre-merge reviewer checklist

Manual testing (e.g. pull and build branch, run in browser, test code being changed)
PR is linked to the appropriate GitHub issue
IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

github-actions · 2023-07-18T00:23:02Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

georgewrmarshall · 2023-07-18T00:34:24Z

No visual regressions

georgewrmarshall · 2023-07-18T00:39:57Z

No visual regressions. Missing image is a build type issue that's not in production

metamaskbot · 2023-07-18T01:05:32Z

Builds ready [bdcb697]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1675 ± 58 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	107	148	134	11	5
		domContentLoaded	1435	1889	1675	120	58
		load	1435	1889	1675	120	58
		domInteractive	1435	1889	1675	120	58

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

codecov · 2023-07-18T01:05:41Z

Codecov Report

Merging #20064 (0ceb6a6) into develop (3f3ee63) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #20064   +/-   ##
========================================
  Coverage    69.42%   69.42%           
========================================
  Files          990      990           
  Lines        37418    37418           
  Branches     10039    10039           
========================================
  Hits         25976    25976           
  Misses       11442    11442

Impacted Files	Coverage Δ
...itutional/compliance-details/compliance-details.js	`90.48% <ø> (ø)`
...institutional/compliance-modal/compliance-modal.js	`100.00% <ø> (ø)`
...utional/compliance-settings/compliance-settings.js	`100.00% <ø> (ø)`
...nts/institutional/custody-labels/custody-labels.js	`90.00% <ø> (ø)`
...tion/interactive-replacement-token-notification.js	`91.89% <ø> (ø)`
...ponents/institutional/jwt-dropdown/jwt-dropdown.js	`92.31% <ø> (ø)`
...ponents/institutional/jwt-url-form/jwt-url-form.js	`72.73% <ø> (ø)`
...nts/institutional/note-to-trader/note-to-trader.js	`80.00% <ø> (ø)`
...network-notification/wrong-network-notification.js	`100.00% <ø> (ø)`

georgewrmarshall · 2023-07-18T04:38:28Z

No visual regression

georgewrmarshall · 2023-07-18T04:39:38Z

No visual regressions

georgewrmarshall · 2023-07-18T04:40:59Z

No visual regressions

georgewrmarshall · 2023-07-18T04:42:33Z

No visual regressions

georgewrmarshall · 2023-07-18T04:45:15Z

Small update to secondary button to use correct component API

georgewrmarshall · 2023-07-18T04:46:33Z

No visual regressions

georgewrmarshall · 2023-07-18T04:47:51Z

No visual regressions

metamaskbot · 2023-07-18T05:20:54Z

Builds ready [0ceb6a6]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1598 ± 83 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	96	167	127	20	9
		domContentLoaded	1404	2018	1597	173	83
		load	1404	2018	1598	172	83
		domInteractive	1403	2018	1597	173	83

Bundle size diffs

background: 0 bytes
ui: 0 bytes
common: 0 bytes

albertolive

Thank you very much @georgewrmarshall, this is something we wanted to do in the near term. ✅ ✅ 🚢

georgewrmarshall self-assigned this Jul 18, 2023

georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jul 18, 2023

georgewrmarshall mentioned this pull request Jul 18, 2023

Update deprecated Text import paths #19986

Closed

georgewrmarshall force-pushed the part/19986/update-text-import-paths-institutional branch 2 times, most recently from 849754e to bdcb697 Compare July 18, 2023 00:30

georgewrmarshall commented Jul 18, 2023

View reviewed changes

georgewrmarshall added 2 commits July 17, 2023 21:48

Updating Text import paths and deprecated consts

b807174

Update to button

0ceb6a6

georgewrmarshall marked this pull request as ready for review July 18, 2023 04:48

georgewrmarshall requested a review from a team as a code owner July 18, 2023 04:48

georgewrmarshall force-pushed the part/19986/update-text-import-paths-institutional branch from bdcb697 to 0ceb6a6 Compare July 18, 2023 04:48

georgewrmarshall requested review from albertolive and garrettbear July 18, 2023 04:48

albertolive approved these changes Jul 18, 2023

View reviewed changes

NidhiKJha approved these changes Jul 18, 2023

View reviewed changes

zone-live approved these changes Jul 18, 2023

View reviewed changes

georgewrmarshall merged commit e75535d into develop Jul 18, 2023

georgewrmarshall deleted the part/19986/update-text-import-paths-institutional branch July 18, 2023 15:15

github-actions Bot locked and limited conversation to collaborators Jul 18, 2023

metamaskbot added the release-10.36.0 Issue or pull request that will be included in release 10.36.0 label Jul 18, 2023

Gudahtt added release-11.1.0 Issue or pull request that will be included in release 11.1.0 and removed release-10.36.0 Issue or pull request that will be included in release 10.36.0 labels Sep 19, 2023

Conversation

georgewrmarshall commented Jul 18, 2023

Explanation

Screenshots/Screencaps

Manual Testing Steps

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Jul 18, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Jul 18, 2023

Uh oh!

codecov Bot commented Jul 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented Jul 18, 2023

Uh oh!

albertolive left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov Bot commented Jul 18, 2023 •

edited

Loading