Use SIWE origin validation logic from @metamask/controller-utils#18518
Merged
legobeat merged 6 commits intoMetaMask:developfrom Apr 25, 2023
Merged
Use SIWE origin validation logic from @metamask/controller-utils#18518legobeat merged 6 commits intoMetaMask:developfrom
legobeat merged 6 commits intoMetaMask:developfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
36f2856 to
9af3673
Compare
0b0b44e to
1d54ca1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
digiwand
reviewed
Apr 12, 2023
2 tasks
92ad5e4 to
25eeff6
Compare
digiwand
previously approved these changes
Apr 19, 2023
Contributor
digiwand
left a comment
There was a problem hiding this comment.
lgtm! approving so it's ready to merge after https://github.com/MetaMask/core/pull/1163/files is merged
This comment was marked as outdated.
This comment was marked as outdated.
4d8566b to
c0fc734
Compare
digiwand
previously approved these changes
Apr 21, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
|
^^ @legobeat also new file conflicts have appeared |
6869f15 to
bce3f67
Compare
brad-decker
approved these changes
Apr 24, 2023
naugtur
approved these changes
Apr 25, 2023
Contributor
Author
|
@SocketSecurity ignore not-really-a-package@1.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR aims to remove the (currently incomplete) origin domain validation logic from the UI layer and use the new implementation from
@metamask/controller-utils.Depends on:
Related issues:
Resolves:
Supersedes:
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist