feat: use siwe detection from @metamask/controller-utils#18409
Merged
feat: use siwe detection from @metamask/controller-utils#18409
Conversation
122b61c to
fe5a61f
Compare
Collaborator
Builds ready [fe5a61f]
Page Load Metrics (1502 ± 53 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Codecov Report
@@ Coverage Diff @@
## develop #18409 +/- ##
===========================================
+ Coverage 65.02% 65.07% +0.05%
===========================================
Files 934 934
Lines 35967 35919 -48
Branches 9235 9225 -10
===========================================
- Hits 23387 23373 -14
+ Misses 12580 12546 -34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
brad-decker
previously approved these changes
Apr 3, 2023
2 tasks
fe5a61f to
2696f98
Compare
matthewwalsh0
approved these changes
Apr 4, 2023
Collaborator
Builds ready [4fb8b1f]
Page Load Metrics (1837 ± 77 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
brad-decker
approved these changes
Apr 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR aims to remove
detectSIWEmethod from the extension code and consume that method from@metamask/controller-utilsIt also removes usage of
detectSIWEfunction fromSignController, because it's already been implemented inPersonalMessageManagerto extend message withsiweparameters. (See related PR here)Related issue:
https://github.com/MetaMask/MetaMask-planning/issues/407
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.