Sign-in With Ethereum SIWE cleanup by digiwand · Pull Request #18230 · MetaMask/metamask-extension

digiwand · 2023-03-18T00:49:10Z

Explanation

minor cleanup around Sign-in With Ethereum logic

Replace deprecated Typography with Text component
rename boolean variable based on https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/docs/rules/naming-convention.md#enforce-that-boolean-variables-are-prefixed-with-an-allowed-verb

no UI/UX changes

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

I've clearly explained:
- What problem this PR is solving
- How this problem was solved
- How reviewers can test my changes
Sufficient automated test coverage has been added

Pre-merge reviewer checklist

Manual testing (e.g. pull and build branch, run in browser, test code being changed)
PR is linked to the appropriate GitHub issue
IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

github-actions · 2023-03-18T00:49:22Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

metamaskbot · 2023-03-18T01:11:49Z

Builds ready [a5b1704]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1759 ± 66 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	103	352	145	61	29
		domContentLoaded	1553	1967	1746	140	67
		load	1554	1967	1759	137	66
		domInteractive	1553	1967	1746	140	67

Bundle size diffs

background: 0 bytes
ui: -510 bytes
common: 0 bytes

codecov · 2023-03-18T01:11:55Z

Codecov Report

Merging #18230 (a5b1704) into develop (f92e463) will decrease coverage by 0.99%.
The diff coverage is 66.67%.

❗ Current head a5b1704 differs from pull request most recent head 6af91bd. Consider uploading reports for the commit 6af91bd to get more accurate results

@@             Coverage Diff             @@
##           develop   #18230      +/-   ##
===========================================
- Coverage    65.15%   64.16%   -0.99%     
===========================================
  Files          936      914      -22     
  Lines        35965    35621     -344     
  Branches      9231     9028     -203     
===========================================
- Hits         23432    22856     -576     
- Misses       12533    12765     +232

Impacted Files	Coverage Δ
...onents/ui/actionable-message/actionable-message.js	`82.22% <ø> (ø)`
...p/signature-request-siwe/signature-request-siwe.js	`67.39% <66.67%> (ø)`

... and 224 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

- this does update styles slightly

digiwand · 2023-04-21T13:48:01Z

updated snapshot to support new Text component usage

metamaskbot · 2023-04-21T14:11:23Z

Builds ready [6af91bd]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1606 ± 82 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	96	132	110	10	5
		domContentLoaded	1419	2015	1583	145	69
		load	1419	2137	1606	171	82
		domInteractive	1419	2015	1583	145	69

Bundle size diffs

background: 0 bytes
ui: 32 bytes
common: 0 bytes

Base automatically changed from update-siwe-actionable-msg-and-support-mm-icon-in-icon-comp to develop March 21, 2023 16:49

digiwand force-pushed the siwe-cleanup branch from afb2765 to 450d246 Compare March 22, 2023 00:52

digiwand added team-confirmations-secure-ux-PR PRs from the confirmations team area-signatures labels Mar 24, 2023

This was referenced Apr 5, 2023

Sign-in With Ethereum (EIP-4361) Refactor #18461

Closed

Sign-in With Ethereum (SIWE)(EIP-4361) Updates #18471

Open

digiwand linked an issue Apr 5, 2023 that may be closed by this pull request

Sign-in With Ethereum (SIWE) Cleanup #18474

Closed

signature-req: replace Typography w/ Text

56a5ef1

- this does update styles slightly

digiwand force-pushed the siwe-cleanup branch from 450d246 to c8dc966 Compare April 20, 2023 18:32

digiwand marked this pull request as ready for review April 20, 2023 18:32

digiwand requested a review from a team as a code owner April 20, 2023 18:32

digiwand requested a review from danjm April 20, 2023 18:32

digiwand added 2 commits April 20, 2023 15:36

siwe: extract showSecurityProviderBanner

081bfda

siwe: rn -> hasAgreedToDomainWarning

9222bab

digiwand force-pushed the siwe-cleanup branch from c8dc966 to 9222bab Compare April 20, 2023 18:51

jpuri previously approved these changes Apr 21, 2023

View reviewed changes

siwe: update snapshot for updated Text usage

6af91bd

digiwand dismissed jpuri’s stale review via 6af91bd April 21, 2023 13:47

digiwand requested a review from jpuri April 21, 2023 13:48

jpuri approved these changes Apr 21, 2023

View reviewed changes

NidhiKJha approved these changes Apr 21, 2023

View reviewed changes

digiwand merged commit 8bfcd5b into develop Apr 21, 2023

digiwand deleted the siwe-cleanup branch April 21, 2023 19:36

github-actions Bot locked and limited conversation to collaborators Apr 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sign-in With Ethereum SIWE cleanup#18230

Sign-in With Ethereum SIWE cleanup#18230
digiwand merged 4 commits intodevelopfrom
siwe-cleanup

digiwand commented Mar 18, 2023 •

edited

Loading

Uh oh!

github-actions Bot commented Mar 18, 2023

Uh oh!

metamaskbot commented Mar 18, 2023

Uh oh!

codecov Bot commented Mar 18, 2023 •

edited

Loading

Uh oh!

digiwand commented Apr 21, 2023

Uh oh!

metamaskbot commented Apr 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

digiwand commented Mar 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Mar 18, 2023

Uh oh!

metamaskbot commented Mar 18, 2023

Uh oh!

codecov Bot commented Mar 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

digiwand commented Apr 21, 2023

Uh oh!

metamaskbot commented Apr 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

digiwand commented Mar 18, 2023 •

edited

Loading

codecov Bot commented Mar 18, 2023 •

edited

Loading