security: patch request for CVE-2023-28155#18208
Merged
Gudahtt merged 2 commits intoMetaMask:developfrom Mar 17, 2023
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
5b0a19a to
8d8ab81
Compare
digiwand
approved these changes
Mar 17, 2023
Codecov Report
@@ Coverage Diff @@
## develop #18208 +/- ##
===========================================
- Coverage 64.05% 64.04% -0.01%
===========================================
Files 913 913
Lines 35568 35568
Branches 9014 9014
===========================================
- Hits 22781 22779 -2
- Misses 12787 12789 +2 see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This was referenced Mar 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GHSA-p8p7-x288-28g6
Ported from request/request#3444
This is notably used by
web3-provider-engineand the reason CI deps audits indevelopis currently failing: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/39790/workflows/8a74f244-ffc4-4323-b909-95c5e403885d/jobs/1096152