Added the ability to navigate multiple SIWE notifications#18103
Merged
Added the ability to navigate multiple SIWE notifications#18103
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [f5dbbbb]
Page Load Metrics (1693 ± 70 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #18103 +/- ##
========================================
Coverage 70.04% 70.04%
========================================
Files 962 962
Lines 36875 36893 +18
Branches 9468 9470 +2
========================================
+ Hits 25826 25840 +14
- Misses 11049 11053 +4
|
Contributor
|
Verified by QA |
Collaborator
Builds ready [e14a7ee]
Page Load Metrics (1737 ± 80 ms)
Bundle size diffs
|
Contributor
|
Does this need changes so it passes codecov check? |
Contributor
Author
I am not sure what should i do here, since this component doesnt have unit test file |
Collaborator
Builds ready [14287f0]
Page Load Metrics (1638 ± 70 ms)
Bundle size diffs
|
Collaborator
Builds ready [dda3a40]
Page Load Metrics (1634 ± 54 ms)
Bundle size diffs
|
Collaborator
Builds ready [edb9eef]
Page Load Metrics (1651 ± 103 ms)
Bundle size diffs
|
# Conflicts: # ui/components/app/signature-request-siwe/signature-request-siwe.js # ui/components/app/signature-request-siwe/signature-request-siwe.test.js
Collaborator
Builds ready [676c2c4]
Page Load Metrics (1608 ± 59 ms)
Bundle size diffs
|
Contributor
|
@aleksandar-mihajlovic It looks both variations of |
digiwand
reviewed
Apr 13, 2023
Contributor
There was a problem hiding this comment.
re: @legobeat's comment. I agree that adding a test when messagesCount < 1 would be a good addition
edit:
Thanks @aleksandar-mihajlovic for creating this PR and adding the feature support! As discussed with the team, I can get this PR merged. Feel free to reach out to me for anything regarding the PR
Collaborator
Builds ready [7088abe]
Page Load Metrics (1495 ± 26 ms)
Bundle size diffs
|
- remove superfluous mock data - reorganize tests
Collaborator
Builds ready [ef3eba0]
Page Load Metrics (1478 ± 20 ms)
Bundle size diffs
|
Collaborator
Builds ready [27048fc]
Page Load Metrics (1792 ± 71 ms)
Bundle size diffs
|
segun
approved these changes
Jun 7, 2023
Collaborator
Builds ready [ebbf314]
Page Load Metrics (1920 ± 59 ms)
Bundle size diffs
|
Member
|
hi @aleksandar-mihajlovic @digiwand PR looks good from QA side. Great job 🔥 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Added the ability to navigate multiple SIWE notifications, now when user sign's multiple SIWE, the navigation header is shown so that he can go through multiple SIWE and also user has option to RejectAll.
Screenshot
Before
After
Unit tests
Before
After
Lint
Manual Testing Steps