Skip to content

Add e2e test sign in with ethereum#17823

Merged
chloeYue merged 3 commits intodevelopfrom
17051-e2e-siwe
Feb 21, 2023
Merged

Add e2e test sign in with ethereum#17823
chloeYue merged 3 commits intodevelopfrom
17051-e2e-siwe

Conversation

@chloeYue
Copy link
Copy Markdown
Contributor

@chloeYue chloeYue commented Feb 20, 2023

Explanation

Add e2e test sign in with ethereum happypath test.

Pre-merge author checklist

  • I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@chloeYue chloeYue requested a review from a team as a code owner February 20, 2023 10:08
@chloeYue chloeYue requested a review from mcmire February 20, 2023 10:08
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 20, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@chloeYue chloeYue requested review from PeterYinusa and seaona and removed request for mcmire February 20, 2023 10:09
@chloeYue chloeYue added needs-qa Label will automate into QA workspace team-extension-client team-extension-platform Extension Platform team labels Feb 20, 2023
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 20, 2023

Builds ready [4aea7ea]
Page Load Metrics (1897 ± 124 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1023331525225
domContentLoaded151624591861267128
load152224601897258124
domInteractive151624591861267128
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

PeterYinusa
PeterYinusa reviewed Feb 20, 2023
View reviewed changes
Comment thread test/e2e/tests/signin-with-ethereum.spec.js
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 20, 2023

Builds ready [503f5a4]
Page Load Metrics (1563 ± 42 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint97150116147
domContentLoaded1298169215318641
load1378171815638742
domInteractive1298169215318641
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Feb 21, 2023

Builds ready [48a798a]
Page Load Metrics (1728 ± 73 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1002941373919
domContentLoaded14512045168713364
load14522162172815373
domInteractive14512045168713364
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@chloeYue chloeYue merged commit 84aff7c into develop Feb 21, 2023
@chloeYue chloeYue deleted the 17051-e2e-siwe branch February 21, 2023 21:55
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DDDDDanica DDDDDanica DDDDDanica approved these changes

@seaona seaona Awaiting requested review from seaona

+1 more reviewer

@PeterYinusa PeterYinusa PeterYinusa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs-qa Label will automate into QA workspace team-extension-platform Extension Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

e2e Test Coverage SIWE

4 participants

@chloeYue @metamaskbot @DDDDDanica @PeterYinusa