Fix for error during sending to multisig address#17651
Merged
brad-decker merged 1 commit intodevelopfrom Feb 9, 2023
Merged
Conversation
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [fd5ee37]
Page Load Metrics (1287 ± 125 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
jpuri
approved these changes
Feb 8, 2023
brad-decker
approved these changes
Feb 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
If you try to send ETH to a multisig Gnosis Safe wallet address, the transaction fails and you get the below error
Cannot convert string to buffer. toBuffer only supports 0x-prefixed hex strings and this string was given: 0xa021.8This is caused by a bug in how we handle round-ing numbers.
Unable to determine contract standardandCannot convert string to buffererrors appear #17488Screenshots/Screencaps
Before
send-multisig.mp4
After
new.mov
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.