Nit fixes for story-test integration#17344
Merged
Conversation
Collaborator
Builds ready [cf1e9fc]
Page Load Metrics (1317 ± 130 ms)
Bundle size diffs
|
Gudahtt
reviewed
Jan 23, 2023
cf1e9fc to
d1a62b5
Compare
Collaborator
Builds ready [d1a62b5]
Page Load Metrics (1315 ± 107 ms)
Bundle size diffs
|
Collaborator
Builds ready [1b65e29]
Page Load Metrics (1335 ± 141 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #17344 +/- ##
===========================================
- Coverage 60.07% 60.06% -0.01%
===========================================
Files 936 936
Lines 36049 36049
Branches 9261 9261
===========================================
- Hits 21654 21651 -3
- Misses 14395 14398 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
DDDDDanica
approved these changes
Jan 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR for story-test integration PR.
Updated the PR with the fixes @Gudahtt suggested.
Changes Made:
ui/components/app/app-header/app-header.stories.jsstorybook.js