You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't think this should have been approved. The CSS part of this feature is missing and the props do not add the correct styles to the Box component. It also missing testing which I think would have exposed this. Going to re-open the ticket if that's ok @NidhiKJha. I apologize the ticket details were quite sparse so have tried to add more detail which might have avoided this being merged as well. As an aside we should be very critical of any updates made to the Box component it is both a strength and a weakness that all of our components are built upon it. We should be reviewing updates accordingly. I'll make sure our tickets are triaged better and if anything is not clear in the PR or if you are unsure of what updates are included in the PR please comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area-UIRelating to the user interface.team-design-systemAll issues relating to design system in Extension
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to add padding/margin inline-start and inline-end support to the
BoxcomponentFixes #16077