Explanation

Fixes issue where transaction data with omitted 0x will cause wrong transaction type (contract interaction when doing setApprovalForAll, this in turn is causing NFT transfer popup warning to not show up.

Manual Testing Steps

• in test dapp run "set approval for all"
• you should see warning popup

// should show warning confirmation screen after initial confirm
await window.ethereum.request({
  method: 'eth_sendTransaction',
  params: [{
    gas: '0xb403',
    value: '0x0',
    from: ethereum.selectedAddress,
    to: '0x39ec448b891c476e166b3c3242a90830db556661',
    data: '0xa22cb46500000000000000000000000039ec448b891c476e166b3c3242a90830db5566610000000000000000000000000000000000000000000000000000000000000001',
  }],
});

// should show warning confirmation screen after initial confirm, notice data is missisng 0x
await window.ethereum.request({
  method: 'eth_sendTransaction',
  params: [{
    gas: '0xb403',
    value: '0x0',
    from: ethereum.selectedAddress,
    to: '0x39ec448b891c476e166b3c3242a90830db556661',
    data: 'a22cb46500000000000000000000000039ec448b891c476e166b3c3242a90830db5566610000000000000000000000000000000000000000000000000000000000000001'
  }],
});
      

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.