Skip to content

updated colors for typography component#17009

Merged
garrettbear merged 2 commits intodevelopfrom
fix-17005
Jan 5, 2023
Merged

updated colors for typography component#17009
garrettbear merged 2 commits intodevelopfrom
fix-17005

Conversation

@NidhiKJha
Copy link
Copy Markdown
Member

This PR is to fix the propType error in the Box component related to the recent goerli and sepolia update in colors.

Before

Screenshot 2022-12-20 at 6 39 30 PM

After

Screenshot 2022-12-20 at 6 38 59 PM

@NidhiKJha NidhiKJha added area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension labels Dec 20, 2022
@NidhiKJha NidhiKJha requested a review from a team as a code owner December 20, 2022 13:13
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [26dd21b]
Page Load Metrics (3054 ± 328 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1371756496570274
domContentLoaded204448373038688330
load205548373054684328
domInteractive204448373038688330
Bundle size diffs
  • background: 0 bytes
  • ui: 22 bytes
  • common: 0 bytes

highlights:

storybook

Copy link
Copy Markdown
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the update be to add the inverse colors to ValidColors array?

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [99a3551]
Page Load Metrics (2240 ± 151 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1011931272311
domContentLoaded165428862209310149
load175730032240314151
domInteractive165428862209310149
Bundle size diffs
  • background: 0 bytes
  • ui: 82 bytes
  • common: 0 bytes

highlights:

storybook

Copy link
Copy Markdown
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@garrettbear garrettbear merged commit c9ddee9 into develop Jan 5, 2023
@garrettbear garrettbear deleted the fix-17005 branch January 5, 2023 21:04
@github-actions github-actions bot locked and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PropType error supplied to Typography component

4 participants