housekeeping for picker-network#16982
Merged
georgewrmarshall merged 4 commits intodevelopfrom Jan 5, 2023
Merged
Conversation
Collaborator
Builds ready [1638a0f]
Page Load Metrics (2217 ± 167 ms)
Bundle size diffs
highlights: |
Contributor
There was a problem hiding this comment.
Looking good. Couple nits and left this comment in slack channel avatarNetworkProps https://consensys.slack.com/archives/C02VD8QG0LT/p1671587335207129
Collaborator
Builds ready [0caa7b7]
Page Load Metrics (2327 ± 143 ms)
Bundle size diffs
highlights: |
garrettbear
approved these changes
Jan 5, 2023
georgewrmarshall
approved these changes
Jan 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PickerNetwork#16640This PR is to ensure that
PickerNetworkadheres to all of the following conventions and standardsclassNameprop and the PropType descriptions are all the samesizeand are suggesting the use of the generalizeddesign-system.jsconstants e.g.SIZESas the primary option but noting the component consts in the documentation and using them for propType validation and storybook controls onlyimgSrc,imgAlt(html element + attribute) (needs audit)sizeprop would beexport const Size = (args) => (sizeprop would be### SizeColor, Background Color And Border Colorstory inbase-avatar- [ ] yes when it makes sense toButtonBasemm-prefix to all classNamesindex.jsfile in component-library// TODO:comment so we can search for them at a later date e.g. blocking components etcSIZE.MD (32px)