Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jpuri
commented
Nov 21, 2022
| this.on('startUISync', startUISync); | ||
| if (this.startUISync) { | ||
| this.emit('startUISync'); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
In case event listeners were not created when this.emit('startUISync') was called, code above will take care to send event to UI.
Member
There was a problem hiding this comment.
Nit: this might make more sense reformatted as something like
if (this.startUISync) {
startUISync()
} else {
this.on('startUISync', startUISync);
}
e.g. call sync now, otherwise schedule for later. As we don't need the event listener at all if the UI sync is already prepared.
Collaborator
Builds ready [6acfd0b]
Page Load Metrics (1957 ± 128 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR addresses comment: #15558 (comment)