Skip to content

Add transaction security check toggle#16271

Merged
brad-decker merged 4 commits intodevelopfrom
add-transaction-security-check-toggle
Nov 17, 2022
Merged

Add transaction security check toggle#16271
brad-decker merged 4 commits intodevelopfrom
add-transaction-security-check-toggle

Conversation

@filipsekulic
Copy link
Copy Markdown

@filipsekulic filipsekulic commented Oct 25, 2022

Explanation

Add transaction security check toggle option.

More Information

Screenshots/Screencaps

Before

Before.mov

After

After.mov

Manual Testing Steps

Go to Settings > Experimental and check Transaction security check at the top.

@filipsekulic filipsekulic self-assigned this Oct 25, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 25, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mirjanaKukic
Copy link
Copy Markdown
Contributor

mirjanaKukic commented Oct 26, 2022

Verified by QA

@filipsekulic filipsekulic marked this pull request as ready for review October 26, 2022 11:12
@filipsekulic filipsekulic requested a review from a team as a code owner October 26, 2022 11:12
@filipsekulic filipsekulic requested a review from danjm October 26, 2022 11:12
@bschorchit bschorchit mentioned this pull request Oct 28, 2022
Closed
@filipsekulic filipsekulic force-pushed the add-transaction-security-check-toggle branch 2 times, most recently from 2a7b603 to c8bf182 Compare October 31, 2022 17:38
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Oct 31, 2022

Builds ready [c8bf182]
Page Load Metrics (2229 ± 111 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint892480231516248
domContentLoaded178826332212242116
load184926332229231111
domInteractive178826332212242116

highlights:

storybook

darkwing
darkwing previously requested changes Nov 4, 2022
View reviewed changes
Comment thread ui/pages/settings/experimental-tab/experimental-tab.component.js
@filipsekulic filipsekulic force-pushed the add-transaction-security-check-toggle branch from c8bf182 to 9bc87e8 Compare November 8, 2022 09:58
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Nov 8, 2022

Builds ready [9bc87e8]
Page Load Metrics (3104 ± 230 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1211131374353169
domContentLoaded235240783080468225
load236441803104479230
domInteractive235240783080468225

highlights:

storybook

@filipsekulic filipsekulic requested a review from darkwing November 8, 2022 11:16
@filipsekulic filipsekulic force-pushed the add-transaction-security-check-toggle branch from 9e2f82f to 25d3c23 Compare November 8, 2022 11:19
@filipsekulic filipsekulic force-pushed the add-transaction-security-check-toggle branch from 25d3c23 to 43e1686 Compare November 9, 2022 12:40
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Nov 9, 2022

Builds ready [93002fa]
Page Load Metrics (2420 ± 152 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint963098265650312
domContentLoaded172731002396301145
load179631912420316152
domInteractive172730992396301145

highlights:

storybook

danjm
danjm approved these changes Nov 10, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brad-decker brad-decker dismissed darkwing’s stale review November 16, 2022 22:39

changes done as requested.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Nov 16, 2022

Builds ready [b06e84b]
Page Load Metrics (2084 ± 85 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint902681153718
domContentLoaded17302336207218187
load17302336208417785
domInteractive17302336207218187
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 758 bytes
  • ui: 14817 bytes
  • common: 306 bytes

highlights:

storybook

@brad-decker brad-decker merged commit 3746ad9 into develop Nov 17, 2022
@brad-decker brad-decker deleted the add-transaction-security-check-toggle branch November 17, 2022 14:13
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@darkwing darkwing Awaiting requested review from darkwing

2 more reviewers

@brad-decker brad-decker brad-decker approved these changes

@danjm danjm danjm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@filipsekulic filipsekulic

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Wallet Tx Security Provider: Turn On/OFF TX Security Provider Toggle

6 participants

@filipsekulic @mirjanaKukic @metamaskbot @darkwing @brad-decker @danjm