Update signature request screens#15776
Merged
amerkadicE merged 1 commit intodevelopfrom Nov 30, 2022
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Collaborator
Builds ready [54538be]
Page Load Metrics (1827 ± 53 ms)
highlights:storybook
|
Contributor
|
Verified by QA |
f553169 to
316da8c
Compare
Collaborator
Builds ready [316da8c]
Page Load Metrics (1729 ± 49 ms)
highlights:storybook
|
e1a2731 to
0e7a763
Compare
Collaborator
Builds ready [0e7a763]
Page Load Metrics (2181 ± 62 ms)
highlights:storybook
|
danjm
reviewed
Oct 20, 2022
danjm
reviewed
Oct 20, 2022
danjm
previously requested changes
Oct 20, 2022
Contributor
danjm
left a comment
There was a problem hiding this comment.
Only one issue, found in two files, that I've commented on
Collaborator
Builds ready [a0b9f77]
Page Load Metrics (2221 ± 56 ms)
highlights:storybook
|
brad-decker
suggested changes
Nov 5, 2022
217ff6d to
3c41235
Compare
Collaborator
Builds ready [fd526a7]
Page Load Metrics (2409 ± 135 ms)
highlights:storybook
|
brad-decker
previously approved these changes
Nov 9, 2022
Contributor
Could you give this a new review once you have time, @danjm ? |
886ee31 to
7dea863
Compare
Collaborator
Builds ready [7dea863]
Page Load Metrics (2256 ± 187 ms)
Bundle size diffs
highlights:storybook
|
Fix e2e test Update siteicon for v4 signature type Code refactor Code refactor Remove origin and address in signatrue request Update e2e tests Use getNetworkName function Move header component inline jsx Update snaps
7dea863 to
104be10
Compare
8 tasks
Collaborator
Builds ready [104be10]
Page Load Metrics (2121 ± 125 ms)
Bundle size diffs
highlights:storybook
|
jpuri
reviewed
Nov 30, 2022
Contributor
|
@jpuri those styles are in a snapshot file, if that is your only feedback please upgrade to an approval <3 |
brad-decker
approved these changes
Nov 30, 2022
jpuri
approved these changes
Nov 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Update of signature request screens to support the new header component and origin pill.
More Information
Fixes #15705
Screenshots/Screencaps
Before
After
Manual Testing Steps
Open the test dapp https://metamask.github.io/test-dapp/
Under the Eth Sign section, click on "Sign"
Under the Personal Sign section, click on "Sign"
Under the Sign Typed Data section, click on "Sign"
Under the Sign Typed Data V3 section, click on "Sign"
Under the Sign Typed Data V4 section, click on "Sign"
Check if design is updated for those signature request screens.
Pre-Merge Checklist
+ If there are functional changes: